Maven-JUnit Integration: Support nested and toplevel non-public tests and stabiize result extraction #8664
+266
−89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JUnit allows to declare tests on nested (
NestedClass2
andDoubleNestedClass3
below) and also non public top level classes (PackagedTopLevelNonPublicTest
) in addition to the traditional toplevel class tests (test4
):In addition to that Unittests can be placed in the default package and support the same set of special cases.
This PR adds support for these cases:
In addition while investigating the fix, it was observed, that the unittest result extraction sometimes yielded an incomplete set. I.e. some of the test data was missing. Analysis showed, that he XML reports from maven surefire were not yet written/updated while the console output was already done.
Another identified problem fixed here was incomplete detection of Jupiter (JUnit5) usage in the unittest run.
It is inspired by the work from @ratcashdev.
Closes: #3975
Closes. #3995