Print error message on certificate flash failure (#215)

per1234 · web-flow · commit f07445fc5a50 · 2023-08-28T02:21:16.000-07:00
Previously, if there was a problem during the flashing stage of the certificate flash command invocation, Arduino
Firmware Uploader would exit silently, giving the user no feedback that something had gone wrong other than a generic
exit status 1:

```
$ touch /tmp/cert-with-unsupported-extension.crt  # Create dummy certificate file. Valid certificate is not required for this demo.

$ arduino-fwuploader certificates flash --address COM42 --file /tmp/cert-with-unsupported-extension.crt --fqbn arduino:renesas_uno:unor4wifi

Converting and flashing certificate C:/Users/per/AppData/Local/Temp/cert-with-unsupported-extension.crt

$ echo $?

1
```
diff --git a/cli/certificates/flash.go b/cli/certificates/flash.go
@@ -85,7 +85,7 @@ func runFlash(certificateURLs, certificatePaths []string) {
 	res, flashErr := flashCertificates(uploader, certificateURLs, certificatePaths)
 	feedback.PrintResult(res)
 	if flashErr != nil {
-		os.Exit(int(feedback.ErrGeneric))
+		feedback.Fatal(fmt.Sprintf("Error during certificates flashing: %s", flashErr), feedback.ErrGeneric)
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ func runFlash(certificateURLs, certificatePaths []string) {`
`85`	`85`	`res, flashErr := flashCertificates(uploader, certificateURLs, certificatePaths)`
`86`	`86`	`feedback.PrintResult(res)`
`87`	`87`	`if flashErr != nil {`
`88`		`- os.Exit(int(feedback.ErrGeneric))`
	`88`	`+ feedback.Fatal(fmt.Sprintf("Error during certificates flashing: %s", flashErr), feedback.ErrGeneric)`
`89`	`89`	`}`
`90`	`90`	`}`
`91`	`91`