minor fixes to linear algebra examples

syurkevi · syurkevi · commit 33b05582c55b · 2022-04-22T15:21:31.000-04:00
diff --git a/examples/lin_algebra/cholesky.py b/examples/lin_algebra/cholesky.py
@@ -1,36 +1,45 @@
+#!/usr/bin/env python
+#######################################################
+# Copyright (c) 2022, ArrayFire
+# All rights reserved.
+#
+# This file is distributed under 3-clause BSD license.
+# The complete license agreement can be obtained at:
+# http://arrayfire.com/licenses/BSD-3-Clause
+########################################################
+
 import arrayfire as af
 
 def main():
     try:
-        device = 0
         af.info()
-    
+
         n = 5
-        t = af.randu(n,n)
-        inn = af.matmulNT(t,t) + af.identity(n,n)*n
+        t = af.randu(n, n)
+        arr_in = af.matmulNT(t, t) + af.identity(n, n) * n
 
         print("Running Cholesky InPlace\n")
-        cin_upper = inn
-        cin_lower = inn
-        
+        cin_upper = arr_in.copy()
+        cin_lower = arr_in.copy()
+
         af.cholesky_inplace(cin_upper, True)
         af.cholesky_inplace(cin_lower, False)
 
         print(cin_upper)
         print(cin_lower)
 
-        print("Running Cholesky Out of place\n")
+        print("\nRunning Cholesky Out of place\n")
 
-        out_upper = af.cholesky(inn, True)
-        out_lower = af.cholesky(inn, False)
-        
-        # Do we want to print the array like above? If yes this is correct.
-        print(out_upper[0])
-        print(out_lower[0])
+        out_upper, upper_success = af.cholesky(arr_in, True)
+        out_lower, lower_success = af.cholesky(arr_in, False)
 
+        if upper_success == 0:
+            print(out_upper)
+        if lower_success == 0:
+            print(out_lower)
 
     except Exception as e:
-        print('Error: ',str(e))
+        print('Error: ', str(e))
 
 if __name__ == '__main__':
     main()
diff --git a/examples/lin_algebra/lu.py b/examples/lin_algebra/lu.py
@@ -1,27 +1,32 @@
 #!/usr/bin/env python
+#######################################################
+# Copyright (c) 2022, ArrayFire
+# All rights reserved.
+#
+# This file is distributed under 3-clause BSD license.
+# The complete license agreement can be obtained at:
+# http://arrayfire.com/licenses/BSD-3-Clause
+########################################################
+
 import arrayfire as af
+
 def main():
     try:
-        device = 0
-        #af.setDevice(device)
         af.info()
 
-        inn = af.randu(5,8)
-        print(inn)
-
-        lin = inn
+        in_array = af.randu(5,8)
 
         print("Running LU InPlace\n")
-        # Ask if this is correct.
-        pivot = af.lu_inplace(lin)
-        print(lin)
+        pivot = af.lu_inplace(in_array)
+        print(in_array)
         print(pivot)
 
         print("Running LU with Upper Lower Factorization\n")
-        lower, upper, pivot = af.lu(inn)
+        lower, upper, pivot = af.lu(in_array)
         print(lower)
         print(upper)
         print(pivot)
+
     except Exception as e:
         print('Error: ', str(e))
 
diff --git a/examples/lin_algebra/qr.py b/examples/lin_algebra/qr.py
@@ -1,32 +1,38 @@
 #!/usr/bin/env python
+#######################################################
+# Copyright (c) 2022, ArrayFire
+# All rights reserved.
+#
+# This file is distributed under 3-clause BSD license.
+# The complete license agreement can be obtained at:
+# http://arrayfire.com/licenses/BSD-3-Clause
+########################################################
+
 import arrayfire as af
+
 def main():
     try:
-        #Skip device=argc....
-        device = 0
         af.info()
+        in_array = af.randu(5,8)
 
         print("Running QR InPlace\n")
-        inn = af.randu(5,8)
-        print(inn)
+        q_in = in_array.copy()
+        print(q_in)
 
-        qin = inn
-        tau = af.qr_inplace(qin)
+        tau = af.qr_inplace(q_in)
 
-        print(qin)
+        print(q_in)
         print(tau)
 
         print("Running QR with Q and R factorization\n")
-        q,r,tau = af.qr(inn)
+        q, r, tau = af.qr(in_array)
 
         print(q)
         print(r)
         print(tau)
 
     except Exception as e:
-        print("Error: ",str(e))
-
-
+        print("Error: ", str(e))
 
 if __name__ == '__main__':
     main()
