Description
Is there an existing issue for this?
- I have searched the existing issues
Operating system
Arch linux, 6.3.7-arch1-1
Installation method
Package Manager (from OS)
Betterlockscreen & Dependency-Versions
Betterlockscreen: version: v4.0.4 (dunst: true, feh: true)
i3lock: version 2.13.c.4 © 2010 Michael Stapelberg, © 2015 Cassandra Fox, © 2021 Raymond Li
Version: ImageMagick 7.1.1-11 Q16-HDRI x86_64 21206 https://imagemagick.org
Copyright: (C) 1999 ImageMagick Studio LLC
License: https://imagemagick.org/script/license.php
Features: Cipher DPC HDRI Modules OpenCL OpenMP(4.5)
Delegates (built-in): bzlib cairo djvu fftw fontconfig freetype heic jbig jng jp2 jpeg jxl lcms lqr ltdl lzma openexr pangocairo png raqm raw rsvg tiff webp wmf x xml zip zlib
Compiler: gcc (13.1)
dunst version: 1.9.2
feh version 3.10
Compile-time switches: curl exif inotify help magic stat64 verscmp xinerama
[B] Betterlockscreen
Bug description
Locking the screen does not pause notifications. It executes the prelock (including dunstcl pause) and then directly runs the postlock (dunstcl unpause), resulting in all notifications still being displayed.
It works correctly when suspending, notifications are still paused when the computer resumes.
I am not quite sure why you are not using --nofork
. I found a few issues regarding this (#28, #47), the PR said it would break notification display, but I did not find any resolution. Currently lockselect
never blocks and instead always forks.
This leads to the behaviour, as
betterlockscreen/betterlockscreen
Line 302 in 5cb876d
As far as I understand the no-fork option was disabled for suspension. But the suspend command explicitly forks the lockselect
method (which, as far as I can tell, it does not need to do currently. lockselect
forks, the additional &
doesn't do much):
betterlockscreen/betterlockscreen
Line 298 in 5cb876d
Adding --nofork
and keeping the fork (&
) in the suspend case seems to fix all problems for me, but I am sure there is a good reason it is the way it is? I could manually wrap my lock command in dunstcl set-paused
, but it sounds like something betterlockscreen should be doing correctly in all cases.
Steps to reproduce
- Display some (persistent) notifications
- Run
betterlockscreen -l
- You still see all notifications on the lockscreen :(
Relevant log output
No response