add test for 20

fishercoder1534 · fishercoder1534 · commit 6fdb918b1aca · 2019-10-06T08:05:12.000-07:00
diff --git a/src/main/java/com/fishercoder/solutions/_20.java b/src/main/java/com/fishercoder/solutions/_20.java
@@ -10,26 +10,28 @@
  * The brackets must close in the correct order, "()" and "()[]{}" are all valid but "(]" and "([)]" are not.*/
 public class _20 {
 
-    public boolean isValid(String s) {
-        Deque<Character> stack = new ArrayDeque<>();
-        for (int i = 0; i < s.length(); i++) {
-            if (s.charAt(i) == '(' || s.charAt(i) == '{' || s.charAt(i) == '[') {
-                stack.push(s.charAt(i));
-            } else {
-                if (stack.isEmpty()) {
-                    return false;
+    public static class Solution1 {
+        public boolean isValid(String s) {
+            Deque<Character> stack = new ArrayDeque<>();
+            for (int i = 0; i < s.length(); i++) {
+                if (s.charAt(i) == '(' || s.charAt(i) == '{' || s.charAt(i) == '[') {
+                    stack.push(s.charAt(i));
                 } else {
-                    if (stack.peek() == '(' && s.charAt(i) != ')') {
-                        return false;
-                    } else if (stack.peek() == '{' && s.charAt(i) != '}') {
-                        return false;
-                    } else if (stack.peek() == '[' && s.charAt(i) != ']') {
+                    if (stack.isEmpty()) {
                         return false;
+                    } else {
+                        if (stack.peek() == '(' && s.charAt(i) != ')') {
+                            return false;
+                        } else if (stack.peek() == '{' && s.charAt(i) != '}') {
+                            return false;
+                        } else if (stack.peek() == '[' && s.charAt(i) != ']') {
+                            return false;
+                        }
+                        stack.pop();
                     }
-                    stack.pop();
                 }
             }
+            return stack.isEmpty();
         }
-        return stack.isEmpty();
     }
 }
diff --git a/src/test/java/com/fishercoder/_20Test.java b/src/test/java/com/fishercoder/_20Test.java
@@ -0,0 +1,37 @@
+package com.fishercoder;
+
+import com.fishercoder.solutions._20;
+import org.junit.BeforeClass;
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+
+public class _20Test {
+    private static _20.Solution1 solution1;
+
+    @BeforeClass
+    public static void setup() {
+        solution1 = new _20.Solution1();
+    }
+
+    @Test
+    public void test1() {
+        assertEquals(false, solution1.isValid("(]"));
+    }
+
+    @Test
+    public void test2() {
+        assertEquals(false, solution1.isValid("([)]"));
+    }
+
+    @Test
+    public void test3() {
+        assertEquals(true, solution1.isValid("()[]{}"));
+    }
+
+    @Test
+    public void test4() {
+        assertEquals(true, solution1.isValid("()"));
+    }
+
+}
