Skip to content

Add an interface for transport classes. #12084

New issue
New issue
Closed
Closed
Add an interface for transport classes.#12084
Labels
enhancement
Milestone
4.0.0
@ADmad

Description

@ADmad
ADmad
opened on May 15, 2018
  1. Email class currently does a method_exists($transport, 'send') check for transport instances. It would better if we can an interface for transport classes and check if the interface was implemented instead.

cakephp/src/Mailer/Email.php

Line 1660 in 1cfebf6

if (!method_exists($className, 'send')) {

  1. Also currently you can set className key to an object in transport config, which is a bit weird. I don't think we allow that for any other class name. So the possibility of doing so should be removed IMO. className should always be a string.

cakephp/src/Mailer/Email.php

Line 1635 in 1cfebf6

if (is_object($config['className'])) {

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancement

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
      pFad - Phonifier reborn

      Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

      Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy