-
Notifications
You must be signed in to change notification settings - Fork 83
Update for PHP 8.1+ #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for PHP 8.1+ #369
Conversation
I enabled for now the full set of mult-line declarations, just for testing For now the pressing question is how to get the tests working on modern versions of dependencies. |
Anyone any ideas on the blocker of tests getting green again? |
Whats the state of this PR? |
This looks like it needs a bit of rework now. |
@dereuromark I see you have added a few more rules regarding trailing comma besides the one I added in #398. So if you want to get them into the next minor now would be the time. BTW PER 2.0 has added rules regarding trailing comma, so it would be good to follow that https://www.php-fig.org/per/coding-style/#26-trailing-commas phpcs still doesn't seem to have a PER 2.0 rules set but hopefully it will have one soon making things easier for it. |
41f7483
to
4670bf1
Compare
I rebased and ran a test con cakephp/cakephp: |
I ran into slevomat/coding-standard#1715 by the way, also happens without my updates, so this is an issue we need to tackle separately.. |
That's fine, better to stay consistent about the trailing comma along all constructs. It's not a problem as long as it's auto fixable.
The slevomat guys a usually pretty responsive, so hopefully should be resolved soon. |
I added PHPStan. |
First stab at #368
It will also require test harness to be fixed up for 8.1+
As well as (follow-ups?):