fix(policy): synchronize policy_map updates in update and remove

Victor-Bayim · Victor-Bayim · commit 068de061af03 · 2025-03-22T16:30:08.000+08:00
diff --git a/casbin/model/policy.py b/casbin/model/policy.py
@@ -187,8 +187,6 @@ def update_policy(self, sec, ptype, old_rule, new_rule):
 
         return True
 
-
-
     def update_policies(self, sec, ptype, old_rules, new_rules):
         """update policy rules from the model using update_policy for each rule.
         If any update fails, roll back all changes."""
@@ -212,8 +210,6 @@ def update_policies(self, sec, ptype, old_rules, new_rules):
 
         return True
 
-
-
     def remove_policy(self, sec, ptype, rule):
         """removes a policy rule from the model."""
         if not self.has_policy(sec, ptype, rule):
@@ -229,15 +225,13 @@ def remove_policy(self, sec, ptype, rule):
 
         return rule not in assertion.policy
 
-
     def remove_policies(self, sec, ptype, rules):
         """Remove multiple policy rules by sequentially calling remove_policy."""
         for rule in rules:
             if not self.remove_policy(sec, ptype, rule):
                 return False
         return True
 
-
     def remove_policies_with_effected(self, sec, ptype, rules):
         effected = []
         for rule in rules:
@@ -270,15 +264,14 @@ def remove_filtered_policy_returns_effects(self, sec, ptype, field_index, *field
 
         assertion = self[sec][ptype]
         assertion.policy = tmp
-   
+
         new_map = {}
         for idx, r in enumerate(assertion.policy):
             new_map[DEFAULT_SEP.join(r)] = idx
         assertion.policy_map = new_map
 
         return effects
 
-
     def remove_filtered_policy(self, sec, ptype, field_index, *field_values):
         """removes policy rules based on field filters from the model."""
         tmp = []
@@ -297,15 +290,14 @@ def remove_filtered_policy(self, sec, ptype, field_index, *field_values):
 
         assertion = self[sec][ptype]
         assertion.policy = tmp
-    
+
         new_map = {}
         for idx, r in enumerate(assertion.policy):
             new_map[DEFAULT_SEP.join(r)] = idx
         assertion.policy_map = new_map
 
         return res
 
-
     def get_values_for_field_in_policy(self, sec, ptype, field_index):
         """gets all values for a field for all rules in a policy, duplicated values are removed."""
         values = []
@@ -319,4 +311,4 @@ def get_values_for_field_in_policy(self, sec, ptype, field_index):
             if value not in values:
                 values.append(value)
 
-        return values
+        return values
