Fix 0 length bencoded strings

SevereOverfl0w · SevereOverfl0w · commit 90061f8fb61f · 2016-10-12T13:25:52.000+01:00
diff --git a/nrepl/bencode.py b/nrepl/bencode.py
@@ -46,7 +46,7 @@ def _read_int(s, terminator=None, init_data=None):
 
 
 def _read_bytes(s, n):
-    data = StringIO()
+    data = StringIO('')
     cnt = 0
     while cnt < n:
         m = s.read(n - cnt)
@@ -95,7 +95,7 @@ def _read_map(s):
 
 def _read_datum(s):
     delim = _read_delimiter(s)
-    if delim:
+    if delim is not '':
         return _read_fns.get(delim, lambda s: _read_bytes(s, delim))(s)
 
 
@@ -135,7 +135,7 @@ def encode(v):
 def decode_file(file):
     while True:
         x = _read_datum(file)
-        if not x:
+        if x is None:
             break
         yield x
 
diff --git a/test.py b/test.py
@@ -23,6 +23,12 @@ def test_encoding (self):
         self.assertEqual([{u'a': 1, u'c': [{u'x': [u'y']}], u'b': [2, [3]]}],
                 list(decode('d1:ai1e1:cld1:xl1:yeee1:bli2eli3eeee')))
 
+    def test_empty_string (self):
+        self.assertEqual(['a'], list(decode('1:a')))
+        self.assertEqual([''], list(decode('0:')))
+        self.assertEqual([['spam', '', 'a', 'ab']], list(decode('l4:spam0:1:a2:abe')))
+        self.assertEqual([{'spam': ''}], list(decode('d4:spam0:e')))
+
 class REPLTest (unittest.TestCase):
     def setUp (self):
         # this here only to accommodate travis, which puts leiningen @ lein2
