chore: make browser.newPage device-friendly (microsoft#203)

pavelfeldman · web-flow · commit 048cc223899f · 2020-09-28T16:13:54.000-07:00
diff --git a/playwright/async_api.py b/playwright/async_api.py
@@ -5643,6 +5643,7 @@ async def newPage(
         hasTouch: bool = None,
         colorScheme: Literal["dark", "light", "no-preference"] = None,
         acceptDownloads: bool = None,
+        defaultBrowserType: str = None,
     ) -> "Page":
         """Browser.newPage
 
@@ -5708,6 +5709,7 @@ async def newPage(
                 hasTouch=hasTouch,
                 colorScheme=colorScheme,
                 acceptDownloads=acceptDownloads,
+                defaultBrowserType=defaultBrowserType,
             )
         )
 
diff --git a/playwright/browser.py b/playwright/browser.py
@@ -120,8 +120,13 @@ async def newPage(
         hasTouch: bool = None,
         colorScheme: ColorScheme = None,
         acceptDownloads: bool = None,
+        defaultBrowserType: str = None,
     ) -> Page:
         params = locals_to_params(locals())
+        # Python is strict in which variables gets passed to methods. We get this
+        # value from the device descriptors, thats why we have to strip it out.
+        if "defaultBrowserType" in params:
+            del params["defaultBrowserType"]
         context = await self.newContext(**params)
         page = await context.newPage()
         page._owned_context = context
diff --git a/playwright/sync_api.py b/playwright/sync_api.py
@@ -5875,6 +5875,7 @@ def newPage(
         hasTouch: bool = None,
         colorScheme: Literal["dark", "light", "no-preference"] = None,
         acceptDownloads: bool = None,
+        defaultBrowserType: str = None,
     ) -> "Page":
         """Browser.newPage
 
@@ -5941,6 +5942,7 @@ def newPage(
                     hasTouch=hasTouch,
                     colorScheme=colorScheme,
                     acceptDownloads=acceptDownloads,
+                    defaultBrowserType=defaultBrowserType,
                 )
             )
         )
diff --git a/scripts/expected_api_mismatch.txt b/scripts/expected_api_mismatch.txt
@@ -100,3 +100,4 @@ Parameter type mismatch in Selectors.register(script=): documented as Union[Call
 
 # Device support
 Missing parameter documentation: Browser.newContext(defaultBrowserType=)
+Missing parameter documentation: Browser.newPage(defaultBrowserType=)

Original file line number	Diff line number	Diff line change
`@@ -5643,6 +5643,7 @@ async def newPage(`
`5643`	`5643`	`hasTouch: bool = None,`
`5644`	`5644`	`colorScheme: Literal["dark", "light", "no-preference"] = None,`
`5645`	`5645`	`acceptDownloads: bool = None,`
	`5646`	`+ defaultBrowserType: str = None,`
`5646`	`5647`	`) -> "Page":`
`5647`	`5648`	`"""Browser.newPage`
`5648`	`5649`
`@@ -5708,6 +5709,7 @@ async def newPage(`
`5708`	`5709`	`hasTouch=hasTouch,`
`5709`	`5710`	`colorScheme=colorScheme,`
`5710`	`5711`	`acceptDownloads=acceptDownloads,`
	`5712`	`+ defaultBrowserType=defaultBrowserType,`
`5711`	`5713`	`)`
`5712`	`5714`	`)`
`5713`	`5715`
Original file line number	Diff line number	Diff line change
`@@ -5875,6 +5875,7 @@ def newPage(`
`5875`	`5875`	`hasTouch: bool = None,`
`5876`	`5876`	`colorScheme: Literal["dark", "light", "no-preference"] = None,`
`5877`	`5877`	`acceptDownloads: bool = None,`
	`5878`	`+ defaultBrowserType: str = None,`
`5878`	`5879`	`) -> "Page":`
`5879`	`5880`	`"""Browser.newPage`
`5880`	`5881`
`@@ -5941,6 +5942,7 @@ def newPage(`
`5941`	`5942`	`hasTouch=hasTouch,`
`5942`	`5943`	`colorScheme=colorScheme,`
`5943`	`5944`	`acceptDownloads=acceptDownloads,`
	`5945`	`+ defaultBrowserType=defaultBrowserType,`
`5944`	`5946`	`)`
`5945`	`5947`	`)`
`5946`	`5948`	`)`
Original file line number	Diff line number	Diff line change
`@@ -100,3 +100,4 @@ Parameter type mismatch in Selectors.register(script=): documented as Union[Call`
`100`	`100`
`101`	`101`	`# Device support`
`102`	`102`	`Missing parameter documentation: Browser.newContext(defaultBrowserType=)`
	`103`	`+Missing parameter documentation: Browser.newPage(defaultBrowserType=)`