fix: Don't lose IP data in AppendValueFromString (#2236)

erezrokah · web-flow · commit 6f1db88d0783 · 2025-07-23T10:50:24.000Z
#### Summary Reverts #2205 as we were actually losing the IP data in some cases (in `AppendValueFromString`). This PR ensures we don't lose the IP data ---
diff --git a/schema/testdata.go b/schema/testdata.go
@@ -5,7 +5,6 @@ import (
 	"encoding/base64"
 	"fmt"
 	"math/rand"
-	"net"
 	"strconv"
 	"strings"
 	"time"
@@ -317,11 +316,9 @@ func (tg TestDataGenerator) getExampleJSON(colName string, dataType arrow.DataTy
 
 		// Generate a CIDR prefix length between 8 and 30
 		cidr := 8 + rnd.Intn(23)
-		input := fmt.Sprintf(`%d.%d.%d.%d/%d`, ip[0], ip[1], ip[2], ip[3], cidr)
-		_, data, _ := net.ParseCIDR(input)
 
 		// Format as an IP address with CIDR notation
-		return fmt.Sprintf(`"%s"`, data.String())
+		return fmt.Sprintf(`"%d.%d.%d.%d/%d"`, ip[0], ip[1], ip[2], ip[3], cidr)
 	}
 	if arrow.TypeEqual(dataType, types.ExtensionTypes.MAC) {
 		mac := make([]byte, 6)
diff --git a/types/inet.go b/types/inet.go
@@ -53,10 +53,11 @@ func (b *InetBuilder) AppendValueFromString(s string) error {
 		b.AppendNull()
 		return nil
 	}
-	_, data, err := net.ParseCIDR(s)
+	ip, data, err := net.ParseCIDR(s)
 	if err != nil {
 		return err
 	}
+	data.IP = ip
 	b.Append(data)
 	return nil
 }

Original file line number	Diff line number	Diff line change
`@@ -53,10 +53,11 @@ func (b *InetBuilder) AppendValueFromString(s string) error {`
`53`	`53`	`b.AppendNull()`
`54`	`54`	`return nil`
`55`	`55`	`}`
`56`		`- _, data, err := net.ParseCIDR(s)`
	`56`	`+ ip, data, err := net.ParseCIDR(s)`
`57`	`57`	`if err != nil {`
`58`	`58`	`return err`
`59`	`59`	`}`
	`60`	`+ data.IP = ip`
`60`	`61`	`b.Append(data)`
`61`	`62`	`return nil`
`62`	`63`	`}`