Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cloudquery/plugin-sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 856a751
Choose a base ref
...
head repository: cloudquery/plugin-sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a106888
Choose a head ref
  • 3 commits
  • 4 files changed
  • 2 contributors

Commits on Jul 7, 2025

  1. chore(deps): Update module github.com/cloudquery/plugin-sdk/v4 to v4.…

    …86.2 (#2216)
    
    This PR contains the following updates:
    
    | Package | Type | Update | Change |
    |---|---|---|---|
    | [github.com/cloudquery/plugin-sdk/v4](https://redirect.github.com/cloudquery/plugin-sdk) | require | patch | `v4.86.1` -> `v4.86.2` |
    
    ---
    
    ### Release Notes
    
    <details>
    <summary>cloudquery/plugin-sdk (github.com/cloudquery/plugin-sdk/v4)</summary>
    
    ### [`v4.86.2`](https://redirect.github.com/cloudquery/plugin-sdk/releases/tag/v4.86.2)
    
    [Compare Source](https://redirect.github.com/cloudquery/plugin-sdk/compare/v4.86.1...v4.86.2)
    
    ##### Bug Fixes
    
    -   **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.13.11 ([#&#8203;2211](https://redirect.github.com/cloudquery/plugin-sdk/issues/2211)) ([5d97720](https://redirect.github.com/cloudquery/plugin-sdk/commit/5d9772020c8e1e6c02ddebfb267ce2c888075ecf))
    -   **deps:** Update module github.com/cloudquery/codegen to v0.3.29 ([#&#8203;2214](https://redirect.github.com/cloudquery/plugin-sdk/issues/2214)) ([c7534ba](https://redirect.github.com/cloudquery/plugin-sdk/commit/c7534ba2ed9b30127a8a2ffade77e90f8663ec07))
    -   **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.26.15 ([#&#8203;2212](https://redirect.github.com/cloudquery/plugin-sdk/issues/2212)) ([afcdfd4](https://redirect.github.com/cloudquery/plugin-sdk/commit/afcdfd4b90fbdce8ac47779976a6be4c1615c61a))
    -   Improve usage error wording ([#&#8203;2215](https://redirect.github.com/cloudquery/plugin-sdk/issues/2215)) ([1e2c257](https://redirect.github.com/cloudquery/plugin-sdk/commit/1e2c257d343d7a2a1ac39ee06a6fc6d6659da010))
    
    </details>
    
    ---
    
    ### Configuration
    
    📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
    
    🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
    
    ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
    
    🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
    
    ---
    
     - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
    
    ---
    
    This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate).
    <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC4yMi4xIiwidXBkYXRlZEluVmVyIjoiNDAuMjIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiYXV0b21lcmdlIl19-->
    cq-bot authored Jul 7, 2025
    Configuration menu
    Copy the full SHA
    c1375bb View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2025

  1. feat: Better error when panic happens in UnifiedDiff (#2217)

    #### Summary
    
    We have a test in our ClickHouse destination that is flaky https://github.com/cloudquery/cloudquery/actions/runs/15976814323/job/45061355720#step:9:16
    
    ```
    FAIL: TestPlugin/TestInsert/All (2.80s)
    panic: json: error calling MarshalJSON for type *array.Struct: json: error calling MarshalJSON for type json.RawMessage: unexpected character '' [recovered]
    	panic: json: error calling MarshalJSON for type *array.Struct: json: error calling MarshalJSON for type json.RawMessage: unexpected character ''
    
    goroutine 74 [running]:
    testing.tRunner.func1.2({0x10f42e0, 0xc00104ccf0})
    	/opt/hostedtoolcache/go/1.24.3/x64/src/testing/testing.go:1734 +0x3eb
    testing.tRunner.func1()
    	/opt/hostedtoolcache/go/1.24.3/x64/src/testing/testing.go:1737 +0x696
    panic({0x10f42e0?, 0xc00104ccf0?})
    	/opt/hostedtoolcache/go/1.24.3/x64/src/runtime/panic.go:792 +0x132
    github.com/apache/arrow-go/v18/arrow/array.(*List).GetOneForMarshal(0xc00140be00, 0x0)
    	/home/runner/go/pkg/mod/github.com/apache/arrow-go/v18@v18.3.1/arrow/array/list.go:110 +0x33b
    github.com/apache/arrow-go/v18/arrow/array.(*Struct).GetOneForMarshal(0xc000737b00, 0x0)
    	/home/runner/go/pkg/mod/github.com/apache/arrow-go/v18@v18.3.1/arrow/array/struct.go:212 +0x2d6
    github.com/apache/arrow-go/v18/arrow/array.(*Struct).MarshalJSON(0xc000737b00)
    	/home/runner/go/pkg/mod/github.com/apache/arrow-go/v18@v18.3.1/arrow/array/struct.go:226 +0x189
    github.com/goccy/go-json/internal/encoder.AppendMarshalJSON(0xc000179110, 0xc0009b9860, {0xc000ffdc00, 0x0, 0x400}, {0x119ea80, 0xc000737b00})
    	/home/runner/go/pkg/mod/github.com/goccy/go-json@v0.10.5/internal/encoder/encoder.go:435 +0x472
    github.com/goccy/go-json/internal/encoder/vm.appendMarshalJSON(0xc000179110, 0xc0009b9860, {0xc000ffdc00, 0x0, 0x400}, {0x119ea80, 0xc000737b00})
    	/home/runner/go/pkg/mod/github.com/goccy/go-json@v0.10.5/internal/encoder/vm/util.go:152 +0x85
    github.com/goccy/go-json/internal/encoder/vm.Run(0xc000179110, {0xc000ffdc00, 0x0, 0x400}, 0xc000df6cb0)
    	/home/runner/go/pkg/mod/github.com/goccy/go-json@v0.10.5/internal/encoder/vm/vm.go:271 +0x63c5
    github.com/goccy/go-json.encodeRunCode(0xc000179110, {0xc000ffdc00, 0x0, 0x400}, 0xc000df6cb0)
    	/home/runner/go/pkg/mod/github.com/goccy/go-json@v0.10.5/encode.go:310 +0x235
    github.com/goccy/go-json.encode(0xc000179110, {0x119ea80, 0xc000737b00})
    	/home/runner/go/pkg/mod/github.com/goccy/go-json@v0.10.5/encode.go:235 +0x47d
    github.com/goccy/go-json.marshal({0x119ea80, 0xc000737b00}, {0x0, 0x0, 0x3?})
    	/home/runner/go/pkg/mod/github.com/goccy/go-json@v0.10.5/encode.go:150 +0x16a
    github.com/goccy/go-json.MarshalWithOption(...)
    	/home/runner/go/pkg/mod/github.com/goccy/go-json@v0.10.5/json.go:185
    github.com/goccy/go-json.Marshal({0x119ea80, 0xc000737b00})
    	/home/runner/go/pkg/mod/github.com/goccy/go-json@v0.10.5/json.go:170 +0x3b
    github.com/apache/arrow-go/v18/internal/json.Marshal(...)
    	/home/runner/go/pkg/mod/github.com/apache/arrow-go/v18@v18.3.1/internal/json/json.go:38
    github.com/apache/arrow-go/v18/arrow/array.(*List).GetOneForMarshal(0xc00140b2c0, 0x0)
    	/home/runner/go/pkg/mod/github.com/apache/arrow-go/v18@v18.3.1/arrow/array/list.go:108 +0x26c
    github.com/apache/arrow-go/v18/arrow/array.(*List).MarshalJSON(0xc00140b2c0)
    	/home/runner/go/pkg/mod/github.com/apache/arrow-go/v18@v18.3.1/arrow/array/list.go:124 +0x189
    github.com/apache/arrow-go/v18/arrow/array.stringAt({0x140ee40, 0xc00104d830}, 0x2)
    	/home/runner/go/pkg/mod/github.com/apache/arrow-go/v18@v18.3.1/arrow/array/diff.go:110 +0xbdb
    github.com/apache/arrow-go/v18/arrow/array.Edits.UnifiedDiff({0xc000516000, 0x5, 0x140ee40?}, {0x140ee40, 0xc00104d830}, {0x140ee40, 0xc00104d800})
    	/home/runner/go/pkg/mod/github.com/apache/arrow-go/v18@v18.3.1/arrow/array/diff.go:72 +0x558
    github.com/cloudquery/plugin-sdk/v4/plugin.TableDiff({0x1409f58, 0xc000298000}, {0x1409f58, 0xc000298030})
    	/home/runner/go/pkg/mod/github.com/cloudquery/plugin-sdk/v4@v4.84.2/plugin/diff.go:42 +0x5da
    ```
    
    It's hard to debug the test since:
    1. It's flaky
    2. We don't have enough information when it fails
    
    This PR tries to error out with a bit more information on the data that was used while triggering the panic
    
    
    ---
    erezrokah authored Jul 8, 2025
    Configuration menu
    Copy the full SHA
    a282ce6 View commit details
    Browse the repository at this point in the history
  2. chore(main): Release v4.87.0 (#2218)

    🤖 I have created a release *beep* *boop*
    ---
    
    
    ## [4.87.0](v4.86.2...v4.87.0) (2025-07-08)
    
    
    ### Features
    
    * Better error when panic happens in `UnifiedDiff` ([#2217](#2217)) ([a282ce6](a282ce6))
    
    ---
    This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
    cq-bot authored Jul 8, 2025
    Configuration menu
    Copy the full SHA
    a106888 View commit details
    Browse the repository at this point in the history
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy