fix: Error handling in StreamingBatchWriter #1921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disq
commented
Oct 3, 2024
| } | ||
| defer func() { | ||
| err := w.Close(ctx) | ||
| retErr = errors.Join(retErr, err) |
There was a problem hiding this comment.
New improvement: always do w.Close even we returned an error, and join errors.
erezrokah
approved these changes
Oct 3, 2024
marianogappa
approved these changes
Oct 4, 2024
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Oct 7, 2024
Getting the S3 plugin ready for the [StreamingBatchWriter update](cloudquery/plugin-sdk#1921). ~Incorporates cloudquery/filetypes#579 and cloudquery/plugin-sdk#1921
|
Should be merged after merging: |
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Oct 7, 2024
Getting the GCS plugin ready for the [StreamingBatchWriter update](cloudquery/plugin-sdk#1921). ~Incorporates cloudquery/filetypes#579 and cloudquery/plugin-sdk#1921
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Oct 7, 2024
Getting the azblob plugin ready for the [StreamingBatchWriter update](cloudquery/plugin-sdk#1921). ~Incorporates cloudquery/filetypes#579 and cloudquery/plugin-sdk#1921
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Oct 7, 2024
Getting the file plugin ready for the [StreamingBatchWriter update](cloudquery/plugin-sdk#1921). ~Incorporates cloudquery/filetypes#579 and cloudquery/plugin-sdk#1921
murarustefaan
approved these changes
Jun 5, 2025
disq
commented
Jun 9, 2025
| } | ||
| } | ||
|
|
||
| return w.Close(ctx) | ||
| return errors.Join(errs...) |
There was a problem hiding this comment.
Here we collate the errors from errCh, as well as logging them as they are encountered
przste-go
approved these changes
Jun 9, 2025
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 18, 2025
🤖 I have created a release *beep* *boop* --- ## [4.84.2](v4.84.1...v4.84.2) (2025-06-18) ### Bug Fixes * Add time delay in DeleteStaleAll test for destinations ([#2191](#2191)) ([d98a293](d98a293)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/config to v1.29.15 ([#2189](#2189)) ([9860e20](9860e20)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/licensemanager to v1.31.1 ([#2186](#2186)) ([7647d77](7647d77)) * **deps:** Update module google.golang.org/grpc to v1.72.2 ([#2187](#2187)) ([a999c81](a999c81)) * **deps:** Update module google.golang.org/grpc to v1.73.0 ([#2190](#2190)) ([2e3c192](2e3c192)) * Error handling in StreamingBatchWriter ([#1921](#1921)) ([6d71fb1](6d71fb1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
original PR: #1913
Reverts the revertion, plus more improvements:
ensureOpened()inline-func now got refactored intos.send()and handles the sending as well). The spawned goroutine doesn't refer toinputChdirectly so that it can be replaced incloseFlush().client.Write()returns an error aftermsgsis closed, it's still logged and returned.