chore: update error message for duplicate organization members (#17594)

aslilac · web-flow · commit 12589026b609 · 2025-04-28T14:51:33.000-06:00
Closes coder/internal#345
diff --git a/coderd/members.go b/coderd/members.go
@@ -62,7 +62,8 @@ func (api *API) postOrganizationMember(rw http.ResponseWriter, r *http.Request)
 	}
 	if database.IsUniqueViolation(err, database.UniqueOrganizationMembersPkey) {
 		httpapi.Write(ctx, rw, http.StatusBadRequest, codersdk.Response{
-			Message: "Organization member already exists in this organization",
+			Message: "User is already an organization member",
+			Detail:  fmt.Sprintf("%s is already a member of %s", user.Username, organization.DisplayName),
 		})
 		return
 	}
diff --git a/coderd/members_test.go b/coderd/members_test.go
@@ -26,7 +26,7 @@ func TestAddMember(t *testing.T) {
 		// Add user to org, even though they already exist
 		// nolint:gocritic // must be an owner to see the user
 		_, err := owner.PostOrganizationMember(ctx, first.OrganizationID, user.Username)
-		require.ErrorContains(t, err, "already exists")
+		require.ErrorContains(t, err, "already an organization member")
 	})
 }
 

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,8 @@ func (api API) postOrganizationMember(rw http.ResponseWriter, r http.Request)`
`62`	`62`	`}`
`63`	`63`	`if database.IsUniqueViolation(err, database.UniqueOrganizationMembersPkey) {`
`64`	`64`	`httpapi.Write(ctx, rw, http.StatusBadRequest, codersdk.Response{`
`65`		`- Message: "Organization member already exists in this organization",`
	`65`	`+ Message: "User is already an organization member",`
	`66`	`+ Detail: fmt.Sprintf("%s is already a member of %s", user.Username, organization.DisplayName),`
`66`	`67`	`})`
`67`	`68`	`return`
`68`	`69`	`}`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ func TestAddMember(t *testing.T) {`
`26`	`26`	`// Add user to org, even though they already exist`
`27`	`27`	`// nolint:gocritic // must be an owner to see the user`
`28`	`28`	`_, err := owner.PostOrganizationMember(ctx, first.OrganizationID, user.Username)`
`29`		`- require.ErrorContains(t, err, "already exists")`
	`29`	`+ require.ErrorContains(t, err, "already an organization member")`
`30`	`30`	`})`
`31`	`31`	`}`
`32`	`32`