fix: avoid duplicating logs on Coder Connect Windows (#19052)

deansheather · web-flow · commit 2a430ab43511 · 2025-07-28T14:02:00.000+10:00
The sinks are already added to the logger above, so they're just getting duplicated
diff --git a/cli/vpndaemon_windows.go b/cli/vpndaemon_windows.go
@@ -63,10 +63,7 @@ func (r *RootCmd) vpnDaemonRun() *serpent.Command {
 			defer pipe.Close()
 
 			logger.Info(ctx, "starting tunnel")
-			tunnel, err := vpn.NewTunnel(ctx, logger, pipe, vpn.NewClient(),
-				vpn.UseOSNetworkingStack(),
-				vpn.UseCustomLogSinks(sinks...),
-			)
+			tunnel, err := vpn.NewTunnel(ctx, logger, pipe, vpn.NewClient(), vpn.UseOSNetworkingStack())
 			if err != nil {
 				return xerrors.Errorf("create new tunnel for client: %w", err)
 			}
diff --git a/vpn/tunnel.go b/vpn/tunnel.go
@@ -192,12 +192,6 @@ func UseAsLogger() TunnelOption {
 	}
 }
 
-func UseCustomLogSinks(sinks ...slog.Sink) TunnelOption {
-	return func(t *Tunnel) {
-		t.clientLogger = t.clientLogger.AppendSinks(sinks...)
-	}
-}
-
 func WithClock(clock quartz.Clock) TunnelOption {
 	return func(t *Tunnel) {
 		t.clock = clock

Original file line number	Diff line number	Diff line change
`@@ -192,12 +192,6 @@ func UseAsLogger() TunnelOption {`
`192`	`192`	`}`
`193`	`193`	`}`
`194`	`194`
`195`		`-func UseCustomLogSinks(sinks ...slog.Sink) TunnelOption {`
`196`		`- return func(t *Tunnel) {`
`197`		`- t.clientLogger = t.clientLogger.AppendSinks(sinks...)`
`198`		`- }`
`199`		`-}`
`200`		`-`
`201`	`195`	`func WithClock(clock quartz.Clock) TunnelOption {`
`202`	`196`	`return func(t *Tunnel) {`
`203`	`197`	`t.clock = clock`