Skip to content

Commit 4c0c4d4

Browse files
committed
Merge remote-tracking branch 'origin/main' into jjs/prebuilds-user-group-membership
2 parents 1cd68e3 + 1320b8d commit 4c0c4d4

File tree

339 files changed

+19602
-3222
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

339 files changed

+19602
-3222
lines changed

.claude/docs/DATABASE.md

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,11 @@
2222

2323
### Helper Scripts
2424

25-
| Script | Purpose |
26-
|--------|---------|
27-
| `./coderd/database/migrations/create_migration.sh "migration name"` | Creates new migration files |
28-
| `./coderd/database/migrations/fix_migration_numbers.sh` | Renumbers migrations to avoid conflicts |
29-
| `./coderd/database/migrations/create_fixture.sh "fixture name"` | Creates test fixtures for migrations |
25+
| Script | Purpose |
26+
|---------------------------------------------------------------------|-----------------------------------------|
27+
| `./coderd/database/migrations/create_migration.sh "migration name"` | Creates new migration files |
28+
| `./coderd/database/migrations/fix_migration_numbers.sh` | Renumbers migrations to avoid conflicts |
29+
| `./coderd/database/migrations/create_fixture.sh "fixture name"` | Creates test fixtures for migrations |
3030

3131
### Database Query Organization
3232

@@ -214,6 +214,5 @@ make lint
214214
- [ ] Migration files exist (both up and down)
215215
- [ ] `make gen` run after query changes
216216
- [ ] Audit table updated for new fields
217-
- [ ] In-memory database implementations updated
218217
- [ ] Nullable fields use `sql.Null*` types
219218
- [ ] Authorization context appropriate for endpoint type

.claude/docs/OAUTH2.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,6 @@ Before completing OAuth2 or authentication feature work:
151151
- [ ] Update RBAC permissions for new resources
152152
- [ ] Add audit logging support if applicable
153153
- [ ] Create database migrations with proper defaults
154-
- [ ] Update in-memory database implementations
155154
- [ ] Add comprehensive test coverage including edge cases
156155
- [ ] Verify linting compliance
157156
- [ ] Test both positive and negative scenarios

.claude/docs/TROUBLESHOOTING.md

Lines changed: 25 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -116,20 +116,33 @@ When facing multiple failing tests or complex integration issues:
116116

117117
### Useful Debug Commands
118118

119-
| Command | Purpose |
120-
|---------|---------|
121-
| `make lint` | Run all linters |
122-
| `make gen` | Generate mocks, database queries |
119+
| Command | Purpose |
120+
|----------------------------------------------|---------------------------------------|
121+
| `make lint` | Run all linters |
122+
| `make gen` | Generate mocks, database queries |
123123
| `go test -v ./path/to/package -run TestName` | Run specific test with verbose output |
124-
| `go test -race ./...` | Run tests with race detector |
124+
| `go test -race ./...` | Run tests with race detector |
125125

126126
### LSP Debugging
127127

128-
| Command | Purpose |
129-
|---------|---------|
130-
| `mcp__go-language-server__definition symbolName` | Find function definition |
131-
| `mcp__go-language-server__references symbolName` | Find all references |
132-
| `mcp__go-language-server__diagnostics filePath` | Check for compilation errors |
128+
#### Go LSP (Backend)
129+
130+
| Command | Purpose |
131+
|----------------------------------------------------|------------------------------|
132+
| `mcp__go-language-server__definition symbolName` | Find function definition |
133+
| `mcp__go-language-server__references symbolName` | Find all references |
134+
| `mcp__go-language-server__diagnostics filePath` | Check for compilation errors |
135+
| `mcp__go-language-server__hover filePath line col` | Get type information |
136+
137+
#### TypeScript LSP (Frontend)
138+
139+
| Command | Purpose |
140+
|----------------------------------------------------------------------------|------------------------------------|
141+
| `mcp__typescript-language-server__definition symbolName` | Find component/function definition |
142+
| `mcp__typescript-language-server__references symbolName` | Find all component/type usages |
143+
| `mcp__typescript-language-server__diagnostics filePath` | Check for TypeScript errors |
144+
| `mcp__typescript-language-server__hover filePath line col` | Get type information |
145+
| `mcp__typescript-language-server__rename_symbol filePath line col newName` | Rename across codebase |
133146

134147
## Common Error Messages
135148

@@ -197,6 +210,8 @@ When facing multiple failing tests or complex integration issues:
197210

198211
- Check existing similar implementations in codebase
199212
- Use LSP tools to understand code relationships
213+
- For Go code: Use `mcp__go-language-server__*` commands
214+
- For TypeScript/React code: Use `mcp__typescript-language-server__*` commands
200215
- Read related test files for expected behavior
201216

202217
### External Resources

.claude/docs/WORKFLOWS.md

Lines changed: 41 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -127,9 +127,11 @@
127127

128128
## Code Navigation and Investigation
129129

130-
### Using Go LSP Tools (STRONGLY RECOMMENDED)
130+
### Using LSP Tools (STRONGLY RECOMMENDED)
131131

132-
**IMPORTANT**: Always use Go LSP tools for code navigation and understanding. These tools provide accurate, real-time analysis of the codebase and should be your first choice for code investigation.
132+
**IMPORTANT**: Always use LSP tools for code navigation and understanding. These tools provide accurate, real-time analysis of the codebase and should be your first choice for code investigation.
133+
134+
#### Go LSP Tools (for backend code)
133135

134136
1. **Find function definitions** (USE THIS FREQUENTLY):
135137
- `mcp__go-language-server__definition symbolName`
@@ -145,14 +147,49 @@
145147
- `mcp__go-language-server__hover filePath line column`
146148
- Get type information and documentation at specific positions
147149

150+
#### TypeScript LSP Tools (for frontend code in site/)
151+
152+
1. **Find component/function definitions** (USE THIS FREQUENTLY):
153+
- `mcp__typescript-language-server__definition symbolName`
154+
- Example: `mcp__typescript-language-server__definition LoginPage`
155+
- Quickly navigate to React components, hooks, and utility functions
156+
157+
2. **Find symbol references** (ESSENTIAL FOR UNDERSTANDING IMPACT):
158+
- `mcp__typescript-language-server__references symbolName`
159+
- Locate all usages of components, types, or functions
160+
- Critical for refactoring React components and understanding prop usage
161+
162+
3. **Get type information**:
163+
- `mcp__typescript-language-server__hover filePath line column`
164+
- Get TypeScript type information and JSDoc documentation
165+
166+
4. **Rename symbols safely**:
167+
- `mcp__typescript-language-server__rename_symbol filePath line column newName`
168+
- Rename components, props, or functions across the entire codebase
169+
170+
5. **Check for TypeScript errors**:
171+
- `mcp__typescript-language-server__diagnostics filePath`
172+
- Get compilation errors and warnings for a specific file
173+
148174
### Investigation Strategy (LSP-First Approach)
149175

176+
#### Backend Investigation (Go)
177+
150178
1. **Start with route registration** in `coderd/coderd.go` to understand API endpoints
151-
2. **Use LSP `definition` lookup** to trace from route handlers to actual implementations
152-
3. **Use LSP `references`** to understand how functions are called throughout the codebase
179+
2. **Use Go LSP `definition` lookup** to trace from route handlers to actual implementations
180+
3. **Use Go LSP `references`** to understand how functions are called throughout the codebase
153181
4. **Follow the middleware chain** using LSP tools to understand request processing flow
154182
5. **Check test files** for expected behavior and error patterns
155183

184+
#### Frontend Investigation (TypeScript/React)
185+
186+
1. **Start with route definitions** in `site/src/App.tsx` or router configuration
187+
2. **Use TypeScript LSP `definition`** to navigate to React components and hooks
188+
3. **Use TypeScript LSP `references`** to find all component usages and prop drilling
189+
4. **Follow the component hierarchy** using LSP tools to understand data flow
190+
5. **Check for TypeScript errors** with `diagnostics` before making changes
191+
6. **Examine test files** (`.test.tsx`) for component behavior and expected props
192+
156193
## Troubleshooting Development Issues
157194

158195
### Common Issues

.coderabbit.yaml

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
2+
3+
# CodeRabbit Configuration
4+
# This configuration disables automatic reviews entirely
5+
6+
language: "en-US"
7+
early_access: false
8+
9+
reviews:
10+
# Disable automatic reviews for new PRs, but allow incremental reviews
11+
auto_review:
12+
enabled: false # Disable automatic review of new/updated PRs
13+
drafts: false # Don't review draft PRs automatically
14+
15+
# Other review settings (only apply if manually requested)
16+
profile: "chill"
17+
request_changes_workflow: false
18+
high_level_summary: false
19+
poem: false
20+
review_status: false
21+
collapse_walkthrough: true
22+
high_level_summary_in_walkthrough: true
23+
24+
chat:
25+
auto_reply: true # Allow automatic chat replies
26+
27+
# Note: With auto_review.enabled: false, CodeRabbit will only perform initial
28+
# reviews when manually requested, but incremental reviews and chat replies remain enabled

.github/.linkspector.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,5 +25,6 @@ ignorePatterns:
2525
- pattern: "docs.github.com"
2626
- pattern: "claude.ai"
2727
- pattern: "splunk.com"
28+
- pattern: "stackoverflow.com/questions"
2829
aliveStatusCodes:
2930
- 200

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy