Skip to content

Commit 5a8a19b

Browse files
BrunoQuaresmaBrunoQuaresma
authored
feat: auto reconnect the terminal (#18796)
**Changes:** - Use [websocket-ts](https://www.npmjs.com/package/websocket-ts) to have auto reconnection out of the box 🙏 - Update the disconnected alert message to "Trying to connect..." since the connection is always trying to reconnect - Remove `useWithRetry` because it is not necessary anymore **Other topics:** - The disconnected alert is displaying a simple message, but we can include more info such as the number of attemtps - The reconnection feature is in a good state and adding value. IMO, any improvement can be done after getting this merged Closes coder/internal#659
1 parent 00ba027 commit 5a8a19b

File tree

8 files changed

+47
-450
lines changed

8 files changed

+47
-450
lines changed

‎site/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@
120120
"undici": "6.21.2",
121121
"unique-names-generator": "4.7.1",
122122
"uuid": "9.0.1",
123+
"websocket-ts": "2.2.1",
123124
"yup": "1.6.1"
124125
},
125126
"devDependencies": {

‎site/pnpm-lock.yaml

Lines changed: 8 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎site/src/hooks/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,3 @@ export * from "./useClickable";
33
export * from "./useClickableTableRow";
44
export * from "./useClipboard";
55
export * from "./usePagination";
6-
export * from "./useWithRetry";

‎site/src/hooks/useWithRetry.test.ts

Lines changed: 0 additions & 329 deletions
This file was deleted.

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy