Skip to content

Commit 69a9e03

Browse files
committed
fix: adjust form width and slider value display
1 parent 521b129 commit 69a9e03

File tree

2 files changed

+31
-24
lines changed

2 files changed

+31
-24
lines changed

site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx

Lines changed: 30 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -57,12 +57,14 @@ export const DynamicParameter: FC<DynamicParameterProps> = ({
5757
data-testid={`parameter-field-${parameter.name}`}
5858
>
5959
<ParameterLabel parameter={parameter} isPreset={isPreset} />
60-
<ParameterField
61-
parameter={parameter}
62-
onChange={onChange}
63-
disabled={disabled}
64-
id={id}
65-
/>
60+
<div className="max-w-lg">
61+
<ParameterField
62+
parameter={parameter}
63+
onChange={onChange}
64+
disabled={disabled}
65+
id={id}
66+
/>
67+
</div>
6668
{parameter.diagnostics.length > 0 && (
6769
<ParameterDiagnostics diagnostics={parameter.diagnostics} />
6870
)}
@@ -132,11 +134,6 @@ const ParameterLabel: FC<ParameterLabelProps> = ({ parameter, isPreset }) => {
132134
</Tooltip>
133135
</TooltipProvider>
134136
)}
135-
{parameter.form_type === "slider" && (
136-
<output className="ml-auto font-semibold">
137-
{parameter.value.value}
138-
</output>
139-
)}
140137
</Label>
141138

142139
{hasDescription && (
@@ -296,25 +293,35 @@ const ParameterField: FC<ParameterFieldProps> = ({
296293

297294
case "slider":
298295
return (
299-
<Slider
300-
className="mt-2"
301-
defaultValue={[
302-
Number(
303-
parameter.default_value.valid ? parameter.default_value.value : 0,
304-
),
305-
]}
306-
onValueChange={([value]) => onChange(value.toString())}
307-
min={parameter.validations[0]?.validation_min ?? 0}
308-
max={parameter.validations[0]?.validation_max ?? 100}
309-
disabled={disabled}
310-
/>
296+
<div className="flex flex-row items-baseline gap-3">
297+
<Slider
298+
className="mt-2"
299+
defaultValue={[
300+
Number(
301+
parameter.default_value.valid
302+
? parameter.default_value.value
303+
: 0,
304+
),
305+
]}
306+
onValueChange={([value]) => onChange(value.toString())}
307+
min={parameter.validations[0]?.validation_min ?? 0}
308+
max={parameter.validations[0]?.validation_max ?? 100}
309+
disabled={disabled}
310+
/>
311+
<span className="w-4 font-medium">{parameter.value.value}</span>
312+
</div>
311313
);
312314

313315
case "textarea":
314316
return (
315317
<Textarea
316318
defaultValue={defaultValue}
317319
onChange={(e) => onChange(e.target.value)}
320+
onInput={(e) => {
321+
const target = e.currentTarget;
322+
target.style.height = "auto";
323+
target.style.height = `${target.scrollHeight}px`;
324+
}}
318325
disabled={disabled}
319326
placeholder={
320327
(parameter.styling as { placeholder?: string })?.placeholder

site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ export const CreateWorkspacePageViewExperimental: FC<
259259
Go back
260260
</button>
261261
</div>
262-
<div className="flex flex-col gap-6 max-w-screen-sm mx-auto">
262+
<div className="flex flex-col gap-6 max-w-screen-md mx-auto">
263263
<header className="flex flex-col items-start gap-2 mt-10">
264264
<div className="flex items-center gap-2">
265265
<Avatar

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy