Skip to content

Commit adce52e

Browse files
committed
add todo to fix this later
1 parent fc7b5d7 commit adce52e

File tree

1 file changed

+17
-4
lines changed

1 file changed

+17
-4
lines changed

cli/restart_test.go

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import (
1010

1111
"github.com/coder/coder/v2/cli/clitest"
1212
"github.com/coder/coder/v2/coderd/coderdtest"
13+
"github.com/coder/coder/v2/coderd/util/ptr"
1314
"github.com/coder/coder/v2/codersdk"
1415
"github.com/coder/coder/v2/provisioner/echo"
1516
"github.com/coder/coder/v2/provisionersdk/proto"
@@ -70,7 +71,9 @@ func TestRestart(t *testing.T) {
7071
member, memberUser := coderdtest.CreateAnotherUser(t, client, owner.OrganizationID)
7172
version := coderdtest.CreateTemplateVersion(t, client, owner.OrganizationID, echoResponses())
7273
coderdtest.AwaitTemplateVersionJobCompleted(t, client, version.ID)
73-
template := coderdtest.CreateTemplate(t, client, owner.OrganizationID, version.ID)
74+
template := coderdtest.CreateTemplate(t, client, owner.OrganizationID, version.ID, func(request *codersdk.CreateTemplateRequest) {
75+
request.UseClassicParameterFlow = ptr.Ref(true) // TODO: Remove when dynamic parameters prompt missing ephemeral parameters.
76+
})
7477
workspace := coderdtest.CreateWorkspace(t, member, template.ID, func(request *codersdk.CreateWorkspaceRequest) {
7578
request.RichParameterValues = []codersdk.WorkspaceBuildParameter{
7679
{Name: ephemeralParameterName, Value: "placeholder"},
@@ -186,8 +189,14 @@ func TestRestart(t *testing.T) {
186189
member, memberUser := coderdtest.CreateAnotherUser(t, client, owner.OrganizationID)
187190
version := coderdtest.CreateTemplateVersion(t, client, owner.OrganizationID, echoResponses())
188191
coderdtest.AwaitTemplateVersionJobCompleted(t, client, version.ID)
189-
template := coderdtest.CreateTemplate(t, client, owner.OrganizationID, version.ID)
190-
workspace := coderdtest.CreateWorkspace(t, member, template.ID)
192+
template := coderdtest.CreateTemplate(t, client, owner.OrganizationID, version.ID, func(request *codersdk.CreateTemplateRequest) {
193+
request.UseClassicParameterFlow = ptr.Ref(true) // TODO: Remove when dynamic parameters prompts missing ephemeral parameters
194+
})
195+
workspace := coderdtest.CreateWorkspace(t, member, template.ID, func(request *codersdk.CreateWorkspaceRequest) {
196+
request.RichParameterValues = []codersdk.WorkspaceBuildParameter{
197+
{Name: ephemeralParameterName, Value: "placeholder"},
198+
}
199+
})
191200
coderdtest.AwaitWorkspaceBuildJobCompleted(t, client, workspace.LatestBuild.ID)
192201

193202
inv, root := clitest.New(t, "restart", workspace.Name, "--build-options")
@@ -241,7 +250,11 @@ func TestRestart(t *testing.T) {
241250
version := coderdtest.CreateTemplateVersion(t, client, owner.OrganizationID, echoResponses())
242251
coderdtest.AwaitTemplateVersionJobCompleted(t, client, version.ID)
243252
template := coderdtest.CreateTemplate(t, client, owner.OrganizationID, version.ID)
244-
workspace := coderdtest.CreateWorkspace(t, member, template.ID)
253+
workspace := coderdtest.CreateWorkspace(t, member, template.ID, func(request *codersdk.CreateWorkspaceRequest) {
254+
request.RichParameterValues = []codersdk.WorkspaceBuildParameter{
255+
{Name: ephemeralParameterName, Value: "placeholder"},
256+
}
257+
})
245258
coderdtest.AwaitWorkspaceBuildJobCompleted(t, client, workspace.LatestBuild.ID)
246259

247260
inv, root := clitest.New(t, "restart", workspace.Name,

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy