chore: fix presetParameterAsWorkspaceBuildParameters function

ssncferreira · ssncferreira · commit ae16155a0dac · 2025-07-23T12:18:38.000Z
diff --git a/cli/create.go b/cli/create.go
@@ -297,10 +297,7 @@ func (r *RootCmd) create() *serpent.Command {
 				}
 
 				// Convert preset parameters into workspace build parameters.
-				presetBuildParameters, err := presetParameterAsWorkspaceBuildParameters(preset.Parameters)
-				if err != nil {
-					return xerrors.Errorf("failed to parse preset parameters: %w", err)
-				}
+				presetBuildParameters := presetParameterAsWorkspaceBuildParameters(preset.Parameters)
 				presetParameters = append(presetParameters, presetBuildParameters...)
 
 				// Inform the user which preset was applied and its parameters.
diff --git a/cli/parameter.go b/cli/parameter.go
@@ -100,12 +100,12 @@ func (wpf *workspaceParameterFlags) alwaysPrompt() serpent.Option {
 	}
 }
 
-func presetParameterAsWorkspaceBuildParameters(presetParameters []codersdk.PresetParameter) ([]codersdk.WorkspaceBuildParameter, error) {
+func presetParameterAsWorkspaceBuildParameters(presetParameters []codersdk.PresetParameter) []codersdk.WorkspaceBuildParameter {
 	var params []codersdk.WorkspaceBuildParameter
 	for _, parameter := range presetParameters {
 		params = append(params, codersdk.WorkspaceBuildParameter(parameter))
 	}
-	return params, nil
+	return params
 }
 
 func asWorkspaceBuildParameters(nameValuePairs []string) ([]codersdk.WorkspaceBuildParameter, error) {

Original file line number	Diff line number	Diff line change
`@@ -100,12 +100,12 @@ func (wpf *workspaceParameterFlags) alwaysPrompt() serpent.Option {`
`100`	`100`	`}`
`101`	`101`	`}`
`102`	`102`
`103`		`-func presetParameterAsWorkspaceBuildParameters(presetParameters []codersdk.PresetParameter) ([]codersdk.WorkspaceBuildParameter, error) {`
	`103`	`+func presetParameterAsWorkspaceBuildParameters(presetParameters []codersdk.PresetParameter) []codersdk.WorkspaceBuildParameter {`
`104`	`104`	`var params []codersdk.WorkspaceBuildParameter`
`105`	`105`	`for _, parameter := range presetParameters {`
`106`	`106`	`params = append(params, codersdk.WorkspaceBuildParameter(parameter))`
`107`	`107`	`}`
`108`		`- return params, nil`
	`108`	`+ return params`
`109`	`109`	`}`
`110`	`110`
`111`	`111`	`func asWorkspaceBuildParameters(nameValuePairs []string) ([]codersdk.WorkspaceBuildParameter, error) {`