Test out pipePty implementation

bryphe-coder · bryphe-coder · commit c949d44ae6e7 · 2022-02-12T02:28:28.000Z
diff --git a/cli/login_test.go b/cli/login_test.go
@@ -1,5 +1,3 @@
-//go:build !windows
-
 package cli_test
 
 import (
diff --git a/expect/pty/pty_windows.go b/expect/pty/pty_windows.go
@@ -4,25 +4,26 @@
 package pty
 
 import (
+	"io"
 	"os"
 
-	"golang.org/x/sys/windows"
+	//"golang.org/x/sys/windows"
 
-	"github.com/coder/coder/expect/conpty"
+	//"github.com/coder/coder/expect/conpty"
 )
 
-func newPty() (Pty, error) {
+// func pipePty() (Pty, error) {
 	// We use the CreatePseudoConsole API which was introduced in build 17763
-	vsn := windows.RtlGetVersion()
-	if vsn.MajorVersion < 10 ||
-		vsn.BuildNumber < 17763 {
-		return pipePty()
-	}
+// 	vsn := windows.RtlGetVersion()
+// 	if vsn.MajorVersion < 10 ||
+// 		vsn.BuildNumber < 17763 {
+// 		return pipePty()
+// 	}
 
-	return conpty.New(80, 80)
-}
+// 	return conpty.New(80, 80)
+// }
 
-func pipePty() (Pty, error) {
+func newPty() (Pty, error) {
 	r, w, err := os.Pipe()
 	if err != nil {
 		return nil, err
@@ -43,8 +44,12 @@ func (p *pipePtyVal) OutPipe() *os.File {
 	return p.r
 }
 
-func (p *pipePtyVal) WriteString(string) (int, error) {
-	return p.w.WriteString(string)
+func (p *pipePtyVal) Reader() io.Reader {
+	return p.r
+}
+
+func (p *pipePtyVal) WriteString(str string) (int, error) {
+	return p.w.WriteString(str)
 }
 
 func (p *pipePtyVal) Resize(uint16, uint16) error {
