chore: revert dynamic params as a safe experiment (#17510)

Emyrk · web-flow · commit ca38729840c8 · 2025-04-22T16:21:15.000Z
diff --git a/coderd/coderd.go b/coderd/coderd.go
@@ -1816,10 +1816,10 @@ func ReadExperiments(log slog.Logger, raw []string) codersdk.Experiments {
 	for _, v := range raw {
 		switch v {
 		case "*":
-			exps = append(exps, codersdk.ExperimentsAll...)
+			exps = append(exps, codersdk.ExperimentsSafe...)
 		default:
 			ex := codersdk.Experiment(strings.ToLower(v))
-			if !slice.Contains(codersdk.ExperimentsAll, ex) {
+			if !slice.Contains(codersdk.ExperimentsSafe, ex) {
 				log.Warn(context.Background(), "🐉 HERE BE DRAGONS: opting into hidden experiment", slog.F("experiment", ex))
 			}
 			exps = append(exps, ex)
diff --git a/coderd/experiments.go b/coderd/experiments.go
@@ -29,6 +29,6 @@ func (api *API) handleExperimentsGet(rw http.ResponseWriter, r *http.Request) {
 func handleExperimentsSafe(rw http.ResponseWriter, r *http.Request) {
 	ctx := r.Context()
 	httpapi.Write(ctx, rw, http.StatusOK, codersdk.AvailableExperiments{
-		Safe: codersdk.ExperimentsAll,
+		Safe: codersdk.ExperimentsSafe,
 	})
 }
diff --git a/coderd/experiments_test.go b/coderd/experiments_test.go
@@ -69,8 +69,8 @@ func Test_Experiments(t *testing.T) {
 		experiments, err := client.Experiments(ctx)
 		require.NoError(t, err)
 		require.NotNil(t, experiments)
-		require.ElementsMatch(t, codersdk.ExperimentsAll, experiments)
-		for _, ex := range codersdk.ExperimentsAll {
+		require.ElementsMatch(t, codersdk.ExperimentsSafe, experiments)
+		for _, ex := range codersdk.ExperimentsSafe {
 			require.True(t, experiments.Enabled(ex))
 		}
 		require.False(t, experiments.Enabled("danger"))
@@ -91,8 +91,8 @@ func Test_Experiments(t *testing.T) {
 		experiments, err := client.Experiments(ctx)
 		require.NoError(t, err)
 		require.NotNil(t, experiments)
-		require.ElementsMatch(t, append(codersdk.ExperimentsAll, "danger"), experiments)
-		for _, ex := range codersdk.ExperimentsAll {
+		require.ElementsMatch(t, append(codersdk.ExperimentsSafe, "danger"), experiments)
+		for _, ex := range codersdk.ExperimentsSafe {
 			require.True(t, experiments.Enabled(ex))
 		}
 		require.True(t, experiments.Enabled("danger"))
@@ -131,6 +131,6 @@ func Test_Experiments(t *testing.T) {
 		experiments, err := client.SafeExperiments(ctx)
 		require.NoError(t, err)
 		require.NotNil(t, experiments)
-		require.ElementsMatch(t, codersdk.ExperimentsAll, experiments.Safe)
+		require.ElementsMatch(t, codersdk.ExperimentsSafe, experiments.Safe)
 	})
 }
diff --git a/coderd/prometheusmetrics/prometheusmetrics.go b/coderd/prometheusmetrics/prometheusmetrics.go
@@ -655,7 +655,7 @@ func Experiments(registerer prometheus.Registerer, active codersdk.Experiments)
 		return err
 	}
 
-	for _, exp := range codersdk.ExperimentsAll {
+	for _, exp := range codersdk.ExperimentsSafe {
 		var val float64
 		for _, enabled := range active {
 			if exp == enabled {
diff --git a/coderd/prometheusmetrics/prometheusmetrics_test.go b/coderd/prometheusmetrics/prometheusmetrics_test.go
@@ -612,7 +612,7 @@ func TestAgentStats(t *testing.T) {
 func TestExperimentsMetric(t *testing.T) {
 	t.Parallel()
 
-	if len(codersdk.ExperimentsAll) == 0 {
+	if len(codersdk.ExperimentsSafe) == 0 {
 		t.Skip("No experiments are currently defined; skipping test.")
 	}
 
@@ -624,17 +624,17 @@ func TestExperimentsMetric(t *testing.T) {
 		{
 			name: "Enabled experiment is exported in metrics",
 			experiments: codersdk.Experiments{
-				codersdk.ExperimentsAll[0],
+				codersdk.ExperimentsSafe[0],
 			},
 			expected: map[codersdk.Experiment]float64{
-				codersdk.ExperimentsAll[0]: 1,
+				codersdk.ExperimentsSafe[0]: 1,
 			},
 		},
 		{
 			name:        "Disabled experiment is exported in metrics",
 			experiments: codersdk.Experiments{},
 			expected: map[codersdk.Experiment]float64{
-				codersdk.ExperimentsAll[0]: 0,
+				codersdk.ExperimentsSafe[0]: 0,
 			},
 		},
 		{
diff --git a/codersdk/deployment.go b/codersdk/deployment.go
@@ -3258,13 +3258,11 @@ const (
 	ExperimentDynamicParameters  Experiment = "dynamic-parameters"   // Enables dynamic parameters when creating a workspace.
 )
 
-// ExperimentsAll should include all experiments that are safe for
+// ExperimentsSafe should include all experiments that are safe for
 // users to opt-in to via --experimental='*'.
 // Experiments that are not ready for consumption by all users should
 // not be included here and will be essentially hidden.
-var ExperimentsAll = Experiments{
-	ExperimentDynamicParameters,
-}
+var ExperimentsSafe = Experiments{}
 
 // Experiments is a list of experiments.
 // Multiple experiments may be enabled at the same time.

Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,6 @@ func (api API) handleExperimentsGet(rw http.ResponseWriter, r http.Request) {`
`29`	`29`	`func handleExperimentsSafe(rw http.ResponseWriter, r *http.Request) {`
`30`	`30`	`ctx := r.Context()`
`31`	`31`	`httpapi.Write(ctx, rw, http.StatusOK, codersdk.AvailableExperiments{`
`32`		`- Safe: codersdk.ExperimentsAll,`
	`32`	`+ Safe: codersdk.ExperimentsSafe,`
`33`	`33`	`})`
`34`	`34`	`}`
Original file line number	Diff line number	Diff line change
`@@ -655,7 +655,7 @@ func Experiments(registerer prometheus.Registerer, active codersdk.Experiments)`
`655`	`655`	`return err`
`656`	`656`	`}`
`657`	`657`
`658`		`- for _, exp := range codersdk.ExperimentsAll {`
	`658`	`+ for _, exp := range codersdk.ExperimentsSafe {`
`659`	`659`	`var val float64`
`660`	`660`	`for _, enabled := range active {`
`661`	`661`	`if exp == enabled {`