fix: add missing clause for tracking replacements (#17849)

dannykopping · web-flow · commit f2edcf3f59e6 · 2025-05-15T13:02:30.000+02:00
We should only be tracking resource replacements during a prebuild
claim.

Signed-off-by: Danny Kopping &lt;dannykopping@gmail.com&gt;
diff --git a/coderd/provisionerdserver/provisionerdserver.go b/coderd/provisionerdserver/provisionerdserver.go
@@ -1836,7 +1836,7 @@ func (s *server) CompleteJob(ctx context.Context, completed *proto.CompletedJob)
 			})
 		}
 
-		if s.PrebuildsOrchestrator != nil {
+		if s.PrebuildsOrchestrator != nil && input.PrebuiltWorkspaceBuildStage == sdkproto.PrebuiltWorkspaceBuildStage_CLAIM {
 			// Track resource replacements, if there are any.
 			orchestrator := s.PrebuildsOrchestrator.Load()
 			if resourceReplacements := completed.GetWorkspaceBuild().GetResourceReplacements(); orchestrator != nil && len(resourceReplacements) > 0 {

Original file line number	Diff line number	Diff line change
`@@ -1836,7 +1836,7 @@ func (s server) CompleteJob(ctx context.Context, completed proto.CompletedJob)`
`1836`	`1836`	`})`
`1837`	`1837`	`}`
`1838`	`1838`
`1839`		`- if s.PrebuildsOrchestrator != nil {`
	`1839`	`+ if s.PrebuildsOrchestrator != nil && input.PrebuiltWorkspaceBuildStage == sdkproto.PrebuiltWorkspaceBuildStage_CLAIM {`
`1840`	`1840`	`// Track resource replacements, if there are any.`
`1841`	`1841`	`orchestrator := s.PrebuildsOrchestrator.Load()`
`1842`	`1842`	`if resourceReplacements := completed.GetWorkspaceBuild().GetResourceReplacements(); orchestrator != nil && len(resourceReplacements) > 0 {`