Skip to content

chore(enterprise/coderd/coderdenttest): ensure WorkspaceProxy is connected before returning #19037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore(enterprise/coderd/coderdenttest): ensure WorkspaceProxy is connected before returning #19037

wants to merge 1 commit into from

Conversation

johnstcn
Copy link
Member

Fixes coder/internal#797

It appears that the original flake was due to the wsproxy being shut down before it was completely connected:

    t.go:115: 2025-07-23 11:37:06.540 [erro]  net.workspace-proxy.servertailnet: failed to dial tailnet v2+ API  server_url=http://localhost:43887  error="failed to write msg: failed to write frame: failed to flush: write tcp 127.0.0.1:42412->127.0.0.1:39083: use of closed network connection"
         *** slogtest: log detected at level ERROR; TEST FAILURE ***

This PR creates a test dialer and waits for it to be connected before returning the new WorkspaceProxy.

@johnstcn johnstcn self-assigned this Jul 24, 2025
@johnstcn johnstcn requested review from Emyrk and removed request for Emyrk July 24, 2025 20:32
@johnstcn johnstcn marked this pull request as draft July 25, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flake: enterprise/coderd TestGetCryptoKeys/Unauthorized: servertailnet log error
1 participant
@johnstcn
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy