Skip to content

Commit 9f8558d

Browse files
Address review comments
- Restore discord and godoc badges in README.md - Fix release link to point to correct repository releases page - Use consistent naming for namespace-scoped Role with release prefix - Clean up commented-out legacy securityContext lines in values.yaml The sourceUUID variable is actually used in tests so no changes needed there. YAML formatting in service.yaml is already correct. Co-authored-by: matifali <10648092+matifali@users.noreply.github.com>
1 parent e95d523 commit 9f8558d

File tree

4 files changed

+5
-8
lines changed

4 files changed

+5
-8
lines changed

README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
# coder-logstream-kube
22

3-
[![Go Reference](https://pkg.go.dev/badge/github.com/coder/coder-logstream-kube.svg)](https://pkg.go.dev/github.com/coder/coder-logstream-kube)
3+
[![discord](https://img.shields.io/discord/747933592273027093?label=discord)](https://discord.gg/coder)
4+
[![release](https://img.shields.io/github/v/tag/coder/coder-logstream-kube)](https://github.com/coder/coder-logstream-kube/releases)
5+
[![godoc](https://pkg.go.dev/badge/github.com/coder/coder-logstream-kube.svg)](https://pkg.go.dev/github.com/coder/coder-logstream-kube)
46
[![license](https://img.shields.io/github/license/coder/coder-logstream-kube)](./LICENSE)
57

68
Stream Kubernetes Pod events to the Coder startup logs.

coder-logstream-kube

96.3 MB
Binary file not shown.

helm/templates/service.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ subjects:
4343
apiVersion: rbac.authorization.k8s.io/v1
4444
kind: Role
4545
metadata:
46-
name: coder-logstream-kube-role
46+
name: {{ .Release.Name }}-coder-logstream-kube-role
4747
rules:
4848
- apiGroups: [""]
4949
resources: ["pods", "events"]
@@ -59,7 +59,7 @@ metadata:
5959
roleRef:
6060
apiGroup: rbac.authorization.k8s.io
6161
kind: Role
62-
name: coder-logstream-kube-role
62+
name: {{ .Release.Name }}-coder-logstream-kube-role
6363
subjects:
6464
- kind: ServiceAccount
6565
name: {{ .Values.serviceAccount.name | quote }}

helm/values.yaml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -99,8 +99,3 @@ labels: {}
9999
# securityContext -- Container-level security context
100100
# See: https://kubernetes.io/docs/tasks/configure-pod-container/security-context/
101101
securityContext: {}
102-
# allowPrivilegeEscalation: false
103-
# capabilities:
104-
# drop:
105-
# - ALL
106-
# readOnlyRootFilesystem: true

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy