Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: coder/slog
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.6.1
Choose a base ref
...
head repository: coder/slog
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
  • 10 commits
  • 14 files changed
  • 5 contributors

Commits on Jul 31, 2023

  1. Configuration menu
    Copy the full SHA
    5311545 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. chore: bump golang.org/x/term from 0.10.0 to 0.11.0 (#184)

    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    9f58760 View commit details
    Browse the repository at this point in the history
  2. chore: bump cloud.google.com/go/logging from 1.7.0 to 1.8.1 (#186)

    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    0830a57 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b386d5d View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2023

  1. feat: add more prominent failure notice on slogtest error (#190)

    * feat: add more prominent failure notice on slogtest error
    
    Signed-off-by: Spike Curtis <spike@coder.com>
    
    * reinstated Fatal logs calling tb.Fatal
    
    Signed-off-by: Spike Curtis <spike@coder.com>
    
    ---------
    
    Signed-off-by: Spike Curtis <spike@coder.com>
    spikecurtis authored Sep 1, 2023
    Configuration menu
    Copy the full SHA
    3e17d6d View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. Configuration menu
    Copy the full SHA
    f0c466f View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. feat: ignore context.Canceled by default in slogtest (#207)

    * feat: ignore context.Canceled by default in slogtest
    
    Signed-off-by: Spike Curtis <spike@coder.com>
    
    * code review suggestions
    
    Signed-off-by: Spike Curtis <spike@coder.com>
    
    ---------
    
    Signed-off-by: Spike Curtis <spike@coder.com>
    spikecurtis authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    20367d4 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. ci: fix lint, fmt and upload artifacts (#218)

    * chore(.github): update actions/upload-artifacts
    mafredri authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    3e5cea5 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. feat: add IgnoreErrorFn to slogtest options (#217)

    Signed-off-by: Spike Curtis <spike@coder.com>
    spikecurtis authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    0ec81e6 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2025

  1. fix!: handle sql/driver.Valuer types properly in slogjson (#219)

    Currently, if a field like `sql.NullInt32` has `Valid: False`, `sloghuman` will export it's value as `<nil>`, regardless of it's `String`.
    This is because it checks `(driver.Valuer).Value()`.
    
    However, `slogjson` currently sets the value to the json string of the raw struct:
    ```json
    {
      "fields": {
          "Code": "{Int32:0 Valid:false}",
          "ValidCode": "{Int32:12 Valid:true}"
      }
    }
    ```
    
    This PR handles this case by first checking if the type implements `sql/driver.Valuer`. If `Valid` is `false` then a JSON `null` value is produced:
    ```json
    {
      "fields": {
          "Code": null,
          "ValidCode": 12
      }
    }
    ```
    This matches the behaviour of `sloghuman`.
    
    This is technically a breaking change, as these types are now `T | null` instead of `String`, where `T` is the corresponding JSON type of `sql.Null<V>`
    ethanndickson authored Jul 3, 2025
    Configuration menu
    Copy the full SHA
    9df5e0a View commit details
    Browse the repository at this point in the history
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy