-
Notifications
You must be signed in to change notification settings - Fork 22
Comparing changes
Open a pull request
base repository: coder/slog
base: v1.6.1
head repository: coder/slog
compare: main
- 10 commits
- 14 files changed
- 5 contributors
Commits on Jul 31, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5311545 - Browse repository at this point
Copy the full SHA 5311545View commit details
Commits on Aug 17, 2023
-
chore: bump golang.org/x/term from 0.10.0 to 0.11.0 (#184)
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 9f58760 - Browse repository at this point
Copy the full SHA 9f58760View commit details -
chore: bump cloud.google.com/go/logging from 1.7.0 to 1.8.1 (#186)
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 0830a57 - Browse repository at this point
Copy the full SHA 0830a57View commit details -
Configuration menu - View commit details
-
Copy full SHA for b386d5d - Browse repository at this point
Copy the full SHA b386d5dView commit details
Commits on Sep 1, 2023
-
feat: add more prominent failure notice on slogtest error (#190)
* feat: add more prominent failure notice on slogtest error Signed-off-by: Spike Curtis <spike@coder.com> * reinstated Fatal logs calling tb.Fatal Signed-off-by: Spike Curtis <spike@coder.com> --------- Signed-off-by: Spike Curtis <spike@coder.com>
Configuration menu - View commit details
-
Copy full SHA for 3e17d6d - Browse repository at this point
Copy the full SHA 3e17d6dView commit details
Commits on Sep 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f0c466f - Browse repository at this point
Copy the full SHA f0c466fView commit details
Commits on Jan 26, 2024
-
feat: ignore context.Canceled by default in slogtest (#207)
* feat: ignore context.Canceled by default in slogtest Signed-off-by: Spike Curtis <spike@coder.com> * code review suggestions Signed-off-by: Spike Curtis <spike@coder.com> --------- Signed-off-by: Spike Curtis <spike@coder.com>
Configuration menu - View commit details
-
Copy full SHA for 20367d4 - Browse repository at this point
Copy the full SHA 20367d4View commit details
Commits on Nov 8, 2024
-
ci: fix lint, fmt and upload artifacts (#218)
* chore(.github): update actions/upload-artifacts
Configuration menu - View commit details
-
Copy full SHA for 3e5cea5 - Browse repository at this point
Copy the full SHA 3e5cea5View commit details
Commits on Nov 12, 2024
-
feat: add IgnoreErrorFn to slogtest options (#217)
Signed-off-by: Spike Curtis <spike@coder.com>
Configuration menu - View commit details
-
Copy full SHA for 0ec81e6 - Browse repository at this point
Copy the full SHA 0ec81e6View commit details
Commits on Jul 3, 2025
-
fix!: handle
sql/driver.Valuer
types properly inslogjson
(#219)Currently, if a field like `sql.NullInt32` has `Valid: False`, `sloghuman` will export it's value as `<nil>`, regardless of it's `String`. This is because it checks `(driver.Valuer).Value()`. However, `slogjson` currently sets the value to the json string of the raw struct: ```json { "fields": { "Code": "{Int32:0 Valid:false}", "ValidCode": "{Int32:12 Valid:true}" } } ``` This PR handles this case by first checking if the type implements `sql/driver.Valuer`. If `Valid` is `false` then a JSON `null` value is produced: ```json { "fields": { "Code": null, "ValidCode": 12 } } ``` This matches the behaviour of `sloghuman`. This is technically a breaking change, as these types are now `T | null` instead of `String`, where `T` is the corresponding JSON type of `sql.Null<V>`
Configuration menu - View commit details
-
Copy full SHA for 9df5e0a - Browse repository at this point
Copy the full SHA 9df5e0aView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.6.1...main