Skip to content

Commit ace4462

Browse files
authored
fix: allow dropdown form_type for boolean types (#397)
* fix: allow dropdown form_type for boolean types * add dropdown boolean test
1 parent 01334b6 commit ace4462

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

provider/formtype.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ var formTypeTruthTable = map[OptionType]map[bool][]ParameterFormType{
9999
false: {ParameterFormTypeInput, ParameterFormTypeSlider},
100100
},
101101
OptionTypeBoolean: {
102-
true: {ParameterFormTypeRadio},
102+
true: {ParameterFormTypeRadio, ParameterFormTypeDropdown},
103103
false: {ParameterFormTypeCheckbox, ParameterFormTypeSwitch},
104104
},
105105
OptionTypeListString: {

provider/formtype_test.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,11 @@ func TestValidateFormType(t *testing.T) {
193193
optionType: provider.OptionTypeBoolean,
194194
formType: provider.ParameterFormTypeRadio,
195195
}),
196+
expectSameFormType(formTypeCheck{
197+
options: true,
198+
optionType: provider.OptionTypeBoolean,
199+
formType: provider.ParameterFormTypeDropdown,
200+
}),
196201
expectSameFormType(formTypeCheck{
197202
options: false,
198203
optionType: provider.OptionTypeBoolean,

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy