Disable safari compression compatability layer

nhooyr · nhooyr · commit 4edcada12023 · 2020-04-13T22:57:13.000-04:00
Closes #218
diff --git a/accept.go b/accept.go
@@ -231,8 +231,9 @@ func acceptCompression(r *http.Request, w http.ResponseWriter, mode CompressionM
 		switch ext.name {
 		case "permessage-deflate":
 			return acceptDeflate(w, ext, mode)
-		case "x-webkit-deflate-frame":
-			return acceptWebkitDeflate(w, ext, mode)
+		// Disabled for now, see https://github.com/nhooyr/websocket/issues/218
+		// case "x-webkit-deflate-frame":
+		// 	return acceptWebkitDeflate(w, ext, mode)
 		}
 	}
 	return nil, nil
diff --git a/compress.go b/compress.go
@@ -7,6 +7,7 @@ package websocket
 // by safari. See https://tools.ietf.org/html/draft-tyoshino-hybi-websocket-perframe-deflate-06
 // It will work the same in every way except that we cannot signal to the peer we
 // want to use no context takeover on our side, we can only signal that they should.
+// It is however currently disabled due to Safari bugs. See https://github.com/nhooyr/websocket/issues/218
 type CompressionMode int
 
 const (

Original file line number	Diff line number	Diff line change
`@@ -231,8 +231,9 @@ func acceptCompression(r *http.Request, w http.ResponseWriter, mode CompressionM`
`231`	`231`	`switch ext.name {`
`232`	`232`	`case "permessage-deflate":`
`233`	`233`	`return acceptDeflate(w, ext, mode)`
`234`		`- case "x-webkit-deflate-frame":`
`235`		`- return acceptWebkitDeflate(w, ext, mode)`
	`234`	`+ // Disabled for now, see https://github.com/nhooyr/websocket/issues/218`
	`235`	`+ // case "x-webkit-deflate-frame":`
	`236`	`+ // return acceptWebkitDeflate(w, ext, mode)`
`236`	`237`	`}`
`237`	`238`	`}`
`238`	`239`	`return nil, nil`