Merge pull request rabbitmq#256 from roelrymenants/deadlock

michaelklishin · web-flow · commit 0cb79fad1f41 · 2017-03-03T13:46:57.000+03:00
Reverse lock order to avoid deadlock
diff --git a/src/main/java/com/rabbitmq/client/impl/recovery/AutorecoveringConnection.java b/src/main/java/com/rabbitmq/client/impl/recovery/AutorecoveringConnection.java
@@ -772,8 +772,8 @@ RecordedConsumer deleteRecordedConsumer(String consumerTag) {
     }
 
     void maybeDeleteRecordedAutoDeleteQueue(String queue) {
-        synchronized (this.recordedQueues) {
-            synchronized (this.consumers) {
+        synchronized (this.consumers) {
+            synchronized (this.recordedQueues) {
                 if(!hasMoreConsumersOnQueue(this.consumers.values(), queue)) {
                     RecordedQueue q = this.recordedQueues.get(queue);
                     // last consumer on this connection is gone, remove recorded queue
@@ -787,8 +787,8 @@ void maybeDeleteRecordedAutoDeleteQueue(String queue) {
     }
 
     void maybeDeleteRecordedAutoDeleteExchange(String exchange) {
-        synchronized (this.recordedExchanges) {
-            synchronized (this.consumers) {
+        synchronized (this.consumers) {
+            synchronized (this.recordedExchanges) {
                 if(!hasMoreDestinationsBoundToExchange(Utility.copy(this.recordedBindings), exchange)) {
                     RecordedExchange x = this.recordedExchanges.get(exchange);
                     // last binding where this exchange is the source is gone, remove recorded exchange
