fix(app): wrong additional folder provided, exit with code 0

vogloblinsky · vogloblinsky · commit 15fd3ded9c6b · 2021-12-06T14:11:08.000+01:00
fix #1146
diff --git a/src/app/application.ts b/src/app/application.ts
@@ -239,6 +239,7 @@ export class Application {
                     },
                     errorMessage => {
                         logger.error(errorMessage);
+                        process.exit(0);
                     }
                 );
             },
@@ -251,6 +252,7 @@ export class Application {
                     },
                     errorMessage1 => {
                         logger.error(errorMessage1);
+                        process.exit(0);
                     }
                 );
             }
diff --git a/test/src/cli/cli-additional.spec.ts b/test/src/cli/cli-additional.spec.ts
@@ -1,6 +1,6 @@
 const eol = require('os').EOL;
 import * as chai from 'chai';
-import { temporaryDir, shell, pkg, exists, exec, read, shellAsync } from '../helpers';
+import { temporaryDir, shell, spawn, exists, read, exec } from '../helpers';
 
 const expect = chai.expect;
 const tmp = temporaryDir();
@@ -85,4 +85,43 @@ describe('CLI Additional documentation', () => {
             `<li class="link for-chapter3">${eol}                                                <a href="additional-documentation/edition/edition-of-a-todo/edit-level3.html" data-type="entity-link" data-context="sub-entity" data-context-id="additional">edit-level3</a>${eol}                                            </li>${eol}                                            <li class="link for-chapter4">${eol}                                                <a href="additional-documentation/edition/edition-of-a-todo/edit-level3/edit-level4.html" data-type="entity-link" data-context="sub-entity" data-context-id="additional">edit-level4</a>`
         );
     });
+
+    it('should exit with code 0 if wrong folder provided', () => {});
+});
+
+describe('CLI Additional documentation - wrong folder', () => {
+    let exitCode = 1;
+
+    const distFolder = tmp.name + '-additional-wrong-folder';
+
+    before(done => {
+        tmp.create(distFolder);
+        const ls = exec(
+            'node' +
+                [
+                    '',
+                    './bin/index-cli.js',
+                    '-p',
+                    './test/fixtures/todomvc-ng2/src/tsconfig.json',
+                    '-d',
+                    distFolder,
+                    '-a',
+                    './test/fixtures/todomvc-ng2/screenshots',
+                    '--includes',
+                    './test/fixtures/todomvc-ng2/additional-doc-wrong',
+                    '--includesName',
+                    '"Additional documentation"'
+                ].join(' ')
+        );
+        ls.on('close', code => {
+            exitCode = code;
+            done();
+        });
+    });
+    after(() => tmp.clean(distFolder));
+
+    it('should exit with code 0 if wrong folder provided', () => {
+        expect(exitCode).to.equal(0);
+        // expect(stderrString).to.contain('Error during Additional documentation generation');
+    });
 });

Original file line number	Diff line number	Diff line change
`@@ -239,6 +239,7 @@ export class Application {`
`239`	`239`	`},`
`240`	`240`	`errorMessage => {`
`241`	`241`	`logger.error(errorMessage);`
	`242`	`+ process.exit(0);`
`242`	`243`	`}`
`243`	`244`	`);`
`244`	`245`	`},`
`@@ -251,6 +252,7 @@ export class Application {`
`251`	`252`	`},`
`252`	`253`	`errorMessage1 => {`
`253`	`254`	`logger.error(errorMessage1);`
	`255`	`+ process.exit(0);`
`254`	`256`	`}`
`255`	`257`	`);`
`256`	`258`	`}`