Refactor chunked encoding body parsing.

skystrife · skystrife · commit 30be91da2423 · 2013-02-27T12:22:55.000-06:00
diff --git a/boost/network/protocol/http/client/connection/async_normal.hpp b/boost/network/protocol/http/client/connection/async_normal.hpp
@@ -354,7 +354,10 @@ namespace boost { namespace network { namespace http { namespace impl {
                   this->part.begin()
                   , bytes_transferred
                   );
-                this->body_promise.set_value(body_string);
+                if (this->is_chunk_encoding)
+                  this->body_promise.set_value(parse_chunk_encoding(body_string));
+                else
+                  this->body_promise.set_value(body_string);
               }
               // TODO set the destination value somewhere!
               this->destination_promise.set_value("");
@@ -428,6 +431,34 @@ namespace boost { namespace network { namespace http { namespace impl {
         }
       }
     }
+    
+    string_type parse_chunk_encoding( string_type & body_string ) {
+        string_type body;
+        string_type crlf = "\r\n";
+        
+        typename string_type::iterator begin = body_string.begin();
+        for (typename string_type::iterator iter =
+                std::search(begin, body_string.end(), crlf.begin(), crlf.end());
+                iter != body_string.end();
+                iter = std::search(begin, body_string.end(), crlf.begin(), crlf.end())) {
+            string_type line(begin, iter);
+            if (line.empty())
+                break;
+            std::stringstream stream(line);
+            int len;
+            stream >> std::hex >> len;
+            std::advance(iter, 2);
+            if (!len)
+                break;
+            if (len <= body_string.end() - iter) {
+                body.insert(body.end(), iter, iter + len);
+                std::advance(iter, len);
+            }
+            begin = iter;
+        }
+        
+        return body;
+    }
 
     bool follow_redirect_;
     resolver_type & resolver_;
diff --git a/boost/network/protocol/http/client/connection/async_protocol_handler.hpp b/boost/network/protocol/http/client/connection/async_protocol_handler.hpp
@@ -286,6 +286,11 @@ namespace boost { namespace network { namespace http { namespace impl {
         trim(header_pair.second);
         headers.insert(header_pair);
       }
+      // determine if the body parser will need to handle chunked encoding
+      typename headers_range<basic_response<Tag> >::type transfer_encoding_range = 
+          headers.equal_range("Transfer-Encoding");
+      is_chunk_encoding = !empty(transfer_encoding_range) 
+          && boost::iequals(boost::begin(transfer_encoding_range)->second, "chunked");
       headers_promise.set_value(headers);
     }
 
@@ -373,6 +378,7 @@ namespace boost { namespace network { namespace http { namespace impl {
     buffer_type part;
     typename buffer_type::const_iterator part_begin;
     string_type partial_parsed;
+    bool is_chunk_encoding;
   };
 
 
diff --git a/boost/network/protocol/http/message/async_message.hpp b/boost/network/protocol/http/message/async_message.hpp
@@ -118,34 +118,7 @@ namespace boost { namespace network { namespace http {
         }
 
         string_type const body() const {
-            string_type body;
-            string_type partial_parsed = body_.get();
-
-            typename headers_range<basic_response<Tag> >::type transfer_encoding_range = headers().equal_range("Transfer-Encoding");
-            if (!empty(transfer_encoding_range) && boost::iequals(boost::begin(transfer_encoding_range)->second, "chunked")) {
-                typename string_type::iterator begin = partial_parsed.begin();
-                string_type crlf = "\r\n";
-                for (typename string_type::iterator iter = std::search(begin, partial_parsed.end(), crlf.begin(), crlf.end());
-                        iter != partial_parsed.end();
-                        iter = std::search(begin, partial_parsed.end(), crlf.begin(), crlf.end())) {
-                    string_type line(begin, iter);
-                    if (line.empty()) break;
-                    std::stringstream stream(line);
-                    int len;
-                    stream >> std::hex >> len;
-                    iter += 2;
-                    if (!len) break;
-                    if (len <= partial_parsed.end() - iter) {
-                        body.insert(body.end(), iter, iter + len);
-                        iter += len;
-                    }
-                    begin = iter;
-                }
-            } else {
-                std::swap(body, partial_parsed);
-            }
-
-            return body;
+            return body_.get();
         }
 
         void body(boost::shared_future<string_type> const & future) const {
