add testcase for boost::network::uri::decode

cnagune · cnagune · commit 4ab9e488e1e6 · 2015-08-14T16:03:59.000+09:00
diff --git a/boost/network/uri/decode.hpp b/boost/network/uri/decode.hpp
@@ -59,15 +59,9 @@ OutputIterator decode(const InputIterator &in_begin,
   OutputIterator out = out_begin;
   while (it != in_end) {
     if (*it == '%') {
-      ++it;
-	  if (it == in_end) {
-		throw std::runtime_error("decoding fail because of '%'");
-	  }
+	  if (++it == in_end) throw std::runtime_error("decoding fail because of '%'");
       value_type v0 = detail::letter_to_hex(*it);
-      ++it;
-	  if (it == in_end) {
-		throw std::runtime_error("decoding fail because of '%'");
-	  }
+	  if (++it == in_end) throw std::runtime_error("decoding fail because of '%'");
       value_type v1 = detail::letter_to_hex(*it);
       ++it;
       *out++ = 0x10 * v0 + v1;
diff --git a/libs/network/test/uri/uri_encoding_test.cpp b/libs/network/test/uri/uri_encoding_test.cpp
@@ -47,3 +47,10 @@ BOOST_AUTO_TEST_CASE(decoding_multibyte_test) {
   uri::decode(encoded, std::back_inserter(instance));
   BOOST_CHECK_EQUAL(instance, unencoded);
 }
+
+BOOST_AUTO_TEST_CASE(decoding_throw_test) {
+  const std::string encoded("%");
+
+  std::string instance;
+  BOOST_CHECK_THROW(uri::decoded(encoded), std::runtime_error);
+}
