Skip to content

refactor: replace docker command with docker/cli library, fixes #5862 #7189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

refactor: replace docker command with docker/cli library, fixes #5862 #7189

wants to merge 1 commit into from

Conversation

stasadev
Copy link
Member

@stasadev stasadev commented Apr 5, 2025 •
edited
Loading

The Issue

How This PR Solves The Issue

  • Initial try to use docker/cli in GetDockerContext()
  • Refactor GetDockerClient() to return both client and cli
  • Remove DOCKER_HOST env
  • Replace all direct docker calls with cli

I think all of this will be a step forward for using Podman (without installing the docker client).

Manual Testing Instructions

Automated Testing Overview

Release/Deployment Notes

This will increase the size of the ddev binary.

$ du -h ddev # v1.24.4 release
17M     ddev

$ du -h ddev # DDEV HEAD ddev-linux-amd64.zip
23M     ddev

$ du -h ddev # This PR ddev-linux-amd64.zip
32M     ddev

@github-actions github-actions bot added dependencies Pull requests that update a dependency file maintenance labels Apr 5, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2025 •
edited
Loading

Download the artifacts for this pull request:

See Testing a PR.

Open in GitHub Codespaces

@stasadev stasadev changed the title refactor: replace docker command with docker/cli library, fixes #5862 refactor: replace docker command with docker/cli library, fixes #5862 Apr 5, 2025
@rfay
Copy link
Member

rfay commented Apr 7, 2025

Big progress!

@stasadev stasadev force-pushed the 20250405_stasadev_docker_cli branch from bbe39d2 to c573450 Compare May 20, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stasadev @rfay
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy