-
Notifications
You must be signed in to change notification settings - Fork 141
Feature: Implementations of Range-Separated Hybrid Functionals #6220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…elop into LC_Exx-new All conflicts fixed but you are still merging.
this->MGT.init_Gaunt(2 * Lmax + 1); | ||
// //========================================= | ||
// // (3) make Gaunt coefficients table | ||
// //========================================= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to be an accidental operation.
@@ -79,7 +80,7 @@ template <typename T, typename Tdata> class RPA_LRI | |||
|
|||
// Tdata post_process_Erpa( const Tdata &Erpa_in ) const; | |||
}; | |||
Exx_LRI<double> exx_lri_rpa(GlobalC::exx_info.info_ri); | |||
Exx_LRI<double> exx_lri_rpa(GlobalC::exx_info.info_ri, GlobalC::exx_info.info_ewald); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add namespace for this global class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The class is also need to defined in namespace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The RPA part is not my work; I only modified the initialization code. Further modifications may need to be done by @AroundPeking in his GW implementations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add namespace for Exx_LRI
and RPA_LRI
?
Can this pull request be merged without adding a namespace? The source before it was merged also did not have one.
The namespace can be added later.
Congratulations on your outstanding work! |
Range-separated hybrid (RSH) functionals are a class of hybrid functionals that partition the Fock exchange into short-range and long-range components:

$q\to0$ , two distinct RSH frameworks have been implemented:
To address the divergence issue of the Coulomb potential at
Conventional Spencer-Alavi truncated Coulomb potential
Massidda’s auxiliary-function-modified Ewald summation scheme
This computational framework serves as the foundation for the upcoming implementation of GW and RT-TDDFT-EXX functionalities.