Skip to content

Feature: Implementations of Range-Separated Hybrid Functionals #6220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 451 commits into
base: develop
Choose a base branch
from

Conversation

1041176461
Copy link
Collaborator

@1041176461 1041176461 commented May 16, 2025

Range-separated hybrid (RSH) functionals are a class of hybrid functionals that partition the Fock exchange into short-range and long-range components:
image
To address the divergence issue of the Coulomb potential at $q\to0$, two distinct RSH frameworks have been implemented:

  1. Conventional Spencer-Alavi truncated Coulomb potential

    • More efficient in initialization,
    • but suffers from divergence when computing long-range corrected hybrid functionals (e.g., LC-PBE).
  2. Massidda’s auxiliary-function-modified Ewald summation scheme

    • Resolves the limitations of the Spencer-Alavi truncation method.

This computational framework serves as the foundation for the upcoming implementation of GW and RT-TDDFT-EXX functionalities.

@mohanchen mohanchen requested a review from dyzheng May 25, 2025 06:11
@mohanchen mohanchen added Features Needed The features are indeed needed, and developers should have sophisticated knowledge EXX and lr-TDDFT Related to EXX or lr-TDDFT Refactor Refactor ABACUS codes labels May 25, 2025
this->MGT.init_Gaunt(2 * Lmax + 1);
// //=========================================
// // (3) make Gaunt coefficients table
// //=========================================
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be an accidental operation.

@@ -79,7 +80,7 @@ template <typename T, typename Tdata> class RPA_LRI

// Tdata post_process_Erpa( const Tdata &Erpa_in ) const;
};
Exx_LRI<double> exx_lri_rpa(GlobalC::exx_info.info_ri);
Exx_LRI<double> exx_lri_rpa(GlobalC::exx_info.info_ri, GlobalC::exx_info.info_ewald);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add namespace for this global class.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class is also need to defined in namespace.

Copy link
Collaborator Author

@1041176461 1041176461 May 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RPA part is not my work; I only modified the initialization code. Further modifications may need to be done by @AroundPeking in his GW implementations

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add namespace for Exx_LRI and RPA_LRI?
Can this pull request be merged without adding a namespace? The source before it was merged also did not have one.
The namespace can be added later.

@dyzheng
Copy link
Collaborator

dyzheng commented May 26, 2025

Congratulations on your outstanding work!
From the perspective of long-term code maintenance, I suggest you add sufficient comments to enable other developers to understand the functionality of this part of the code. Unless you promise to respond and maintain all issues related to the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EXX and lr-TDDFT Related to EXX or lr-TDDFT Features Needed The features are indeed needed, and developers should have sophisticated knowledge Refactor Refactor ABACUS codes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy