Skip to content

ci: better release workflow #10325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jul 25, 2025
Merged

ci: better release workflow #10325

merged 19 commits into from
Jul 25, 2025
+646 −22

Conversation

ckohen
Copy link
Member

@ckohen ckohen commented Jun 5, 2024 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:

Creates a proper release workflow, works in ci as well as locally.

This

  • determines the release tree
  • releases all packages in scope, or all packages necessary to release the specified package
  • if a package is already released at a version, the registry check will allow it to skip publishing that package
  •  sanity checks publish completion before moving to the next branch of the release tree
  • creates the tag and publishes a release on github

Status and versioning classification:

@ckohen ckohen requested review from a team and iCrawl as code owners June 5, 2024 12:47
@vercel Vercel
Copy link

vercel bot commented Jun 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2025 9:38am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2025 9:38am

@Jiralite Jiralite added the ci label Jun 5, 2024
almeidx
almeidx reviewed Jun 5, 2024
View reviewed changes
Jiralite
Jiralite reviewed Jun 6, 2024
View reviewed changes
@ckohen ckohen requested review from Jiralite and almeidx June 6, 2024 08:01
Jiralite
Jiralite reviewed Jun 6, 2024
View reviewed changes
@ckohen ckohen force-pushed the ci/better-release branch 2 times, most recently from 8880b32 to 536eeef Compare June 8, 2024 01:16
@ckohen ckohen requested a review from Jiralite June 8, 2024 01:21
Jiralite
Jiralite reviewed Jun 8, 2024
View reviewed changes
kyranet
kyranet approved these changes Jun 9, 2024
View reviewed changes
kyranet
kyranet previously requested changes Jun 9, 2024
View reviewed changes
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, pressed the wrong button 😅

@ckohen ckohen requested a review from kyranet June 9, 2024 16:45
@ckohen ckohen requested a review from vladfrangu June 12, 2024 08:48
vladfrangu
vladfrangu previously requested changes Jun 18, 2024
View reviewed changes
@ckohen ckohen requested a review from vladfrangu June 19, 2024 12:57
vladfrangu
vladfrangu requested changes Jun 19, 2024
View reviewed changes
@ckohen ckohen force-pushed the ci/better-release branch from 970c52e to d526ed9 Compare June 19, 2024 13:06
@codecov Codecov
Copy link

codecov bot commented Jun 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 222 lines in your changes missing coverage. Please review.

Project coverage is 43.88%. Comparing base (f2fec91) to head (6603bb2).

Files with missing lines Patch % Lines
...actions/src/releasePackages/generateReleaseTree.ts 0.00% 156 Missing ⚠️
...ages/actions/src/releasePackages/releasePackage.ts 0.00% 66 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10325      +/-   ##
==========================================
- Coverage   44.42%   43.88%   -0.55%     
==========================================
  Files         308      310       +2     
  Lines       17585    17810     +225     
  Branches     1749     1750       +1     
==========================================
+ Hits         7813     7816       +3     
- Misses       9759     9981     +222     
  Partials       13       13
Flag Coverage Δ
brokers 31.41% <ø> (ø)
builders 79.98% <ø> (ø)
collection 100.00% <ø> (ø)
core 0.88% <ø> (ø)
formatters 99.63% <ø> (ø)
proxy 65.88% <ø> (ø)
rest 87.72% <ø> (+0.03%) ⬆️
structures 85.19% <ø> (ø)
util 43.28% <ø> (ø)
utilities 6.32% <0.00%> (-93.68%) ⬇️
voice 60.25% <ø> (ø)
ws 36.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ckohen ckohen requested a review from vladfrangu June 19, 2024 13:39
@ckohen ckohen force-pushed the ci/better-release branch from 4952578 to c9686b4 Compare August 28, 2024 23:27
@Jiralite Jiralite removed the request for review from suneettipirneni January 11, 2025 13:44
@ckohen ckohen force-pushed the ci/better-release branch from 696a65e to d632267 Compare July 22, 2025 17:43
@ckohen ckohen requested a review from a team as a code owner July 22, 2025 17:43
@ckohen ckohen requested a review from SpaceEEC July 22, 2025 17:43
ckohen and others added 16 commits July 22, 2025 10:50
@ckohen
ci(release): better parsing and exclusions
9a63433
@ckohen
ci(release): remove tree log
bc91bec
@ckohen
ci(release): improve logs
2b21523
@ckohen
ci(release): properly check inputs
938b12c
@ckohen @kyranet
ci(release): better promise handling
fd1d511 
Co-authored-by: Aura <kyradiscord@gmail.com>
@ckohen
ci: refactor release to use bun
0f5b232
@ckohen @vladfrangu
ci(release): whitespace
a0ce780 
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
@ckohen
ci(release): add dev release handling
2271be0
@ckohen
ci(release): fixes from testing
e03c989
@ckohen
ci(release): make the promise run
0eb4af5
@ckohen
ci(release): when specifying package, skip exclusions
2d3e2ae
@ckohen
ci(dev): create-discord-bot dev release
a22f14b
@ckohen
ci(release): improve changelog detection
f46b609
@ckohen
ci: fix typo and allow releasing branches
7df7473
@ckohen
ci(release): set make_latest for gh releases
a2272a9
@ckohen
ci(release): add ssh_key so pushed tags run workflow
beaa4f5
@ckohen ckohen force-pushed the ci/better-release branch from d632267 to beaa4f5 Compare July 22, 2025 17:51
@github-project-automation github-project-automation bot moved this from Review in Progress to Review Approved in discord.js Jul 25, 2025
@iCrawl iCrawl merged commit 6cdfa38 into discordjs:main Jul 25, 2025
26 of 27 checks passed
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jiralite Jiralite Jiralite approved these changes

@almeidx almeidx almeidx left review comments

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@Qjuh Qjuh Qjuh approved these changes

@kyranet kyranet Awaiting requested review from kyranet

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
ci packages:ui
Projects
discord.js
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ckohen @vladfrangu @iCrawl @kyranet @Jiralite @almeidx @Qjuh
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy