Skip to content

Would it make sense to split the functionality of ccount into version_ccount and tag_ccount? #94

@remohoeppli

Description

@remohoeppli

To start, I really love your package. It is super handy and helps a lot to automate the versioning.

The way ccount works currently, it has basically two functions. Either it counts the commits since the last edit of the VERSION file, or it counts the commits since the last Git tag in the git repository graph.

This can introduce an issue into the versioning. Assume we have a feature branch originating from dev. We start to work on it and do some commits. At some point, we set a new tag on the dev branch. If our feature branch originated from the commit of dev, on which we set the tag. This will reset the ccount and possibly give us duplicated version numbers on the feature branch discussed before.

Let me try to visualize this with the following graphs.

setuptools_git_versioning_counter

setuptools_git_versioning_counter_reset

If instead of the ccount, I could use the version_ccount (which only counts the commits since the last changes in the VERSION file), I could prevent the counter from accidentally being reset if someone adds a tag in Git.

I hope this helps to clarify my issue. Please let me know if you need any further information.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      pFad - Phonifier reborn

      Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

      Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy