fix: Console logs are outputted twice when using TestAdapter (#2790)

filzrev · web-flow · commit 799ecfc514f3 · 2025-06-22T18:03:13.000-04:00
* chore: fix issue that console logs are outputted twice when using testadapter

* chore: fix code that are pointed out by code review
diff --git a/src/BenchmarkDotNet.TestAdapter/BenchmarkExecutor.cs b/src/BenchmarkDotNet.TestAdapter/BenchmarkExecutor.cs
@@ -1,4 +1,5 @@
 ﻿using BenchmarkDotNet.Configs;
+using BenchmarkDotNet.Loggers;
 using BenchmarkDotNet.Running;
 using BenchmarkDotNet.TestAdapter.Remoting;
 using Microsoft.VisualStudio.TestPlatform.ObjectModel;
@@ -67,7 +68,10 @@ public void RunBenchmarks(string assemblyPath, TestExecutionRecorderWrapper reco
                 .Select(b => new BenchmarkRunInfo(
                     b.BenchmarksCases,
                     b.Type,
-                    b.Config.AddEventProcessor(eventProcessor).AddLogger(logger).CreateImmutableConfig()))
+                    b.Config.AddEventProcessor(eventProcessor)
+                            .AddLogger(logger)
+                            .RemoveLoggersOfType<ConsoleLogger>() // Console logs are also outputted by VSTestLogger.
+                            .CreateImmutableConfig()))
                 .ToArray();
 
             // Run all the benchmarks, and ensure that any tests that don't have a result yet are sent.
diff --git a/src/BenchmarkDotNet/Configs/ManualConfig.cs b/src/BenchmarkDotNet/Configs/ManualConfig.cs
@@ -327,6 +327,12 @@ public static ManualConfig Union(IConfig globalConfig, IConfig localConfig)
             return manualConfig;
         }
 
+        internal ManualConfig RemoveLoggersOfType<T>()
+        {
+            loggers.RemoveAll(logger => logger is T);
+            return this;
+        }
+
         internal void RemoveAllJobs() => jobs.Clear();
 
         internal void RemoveAllDiagnosers() => diagnosers.Clear();
