chore: Fix x86 disassembler error for net462 #2792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
890a7b4 to
5f6a7d5
Compare
timcassell
approved these changes
Jun 26, 2025
There was a problem hiding this comment.
Very hacky, but I'm going to merge this to get our CI green.
@adamsitnik Maybe you can debug it at some point?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intend to fix issue that CI failed tests for x86 disassembler. (#2789)
What's changed in this PR
Temporary disable
printSourcesettings when running tests for x86 runtime.Additionally.
I've added assertion to check
Errorsproperty of DisassemblyResult to validate returned errors.