Skip to content

Work towards merging TdsParser #2953

Open
Open
@MichelZ

Description

@MichelZ

This is for tracking purposes connected to #1261
I would like to merge TdsParser to a single code base netfx/netcore

The approach I'd like to take is this:

  • Do small PR's first which only change code style to align netfx/netcore codebases
  • Do small PR's that target specific things (e.g. change from Types to type aliases e.g. Int32 to int)
  • Do more PR's that align code but do need code changes

This way (I hope?) changes are small-ish and/or low-riskish, so that they can be reviewed fairly fast (much easier than "big bang" PR's IMHO)

Hope that makes sense, if not just tell me please :)

#2839 also has an impact on this, because removal of SQL 7.0/2000 code means a lot less #IF NETFRAMEWORK constructs, so holding off with aliging SQL7.0/2000 specific code until we know if it needs to stay or can be removed

#3042 Also removes some code that is no longer necessary to merge then

Metadata

Metadata

Assignees

Labels

Common Project 🚮Things that relate to the common project project

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    pFad - Phonifier reborn

    Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

    Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


    Alternative Proxies:

    Alternative Proxy

    pFad Proxy

    pFad v3 Proxy

    pFad v4 Proxy