Swap out Win11 for Win-VS2022 in CI #61743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CI configuration to swap out Win11 for Win-VS2022 and restore coverage for NativeAOT tests while including a helix-matrix trigger for IIS and HttpSys test changes.
- Updated the .azure/pipelines/helix-matrix.yml to include a PR trigger for the main branch.
- Added path filters to run the helix-matrix for IIS and HttpSys related changes.
Files not reviewed (1)
- eng/targets/Helix.Common.props: Language not supported
danmoseley
approved these changes
Apr 29, 2025
This reverts commit 1b00075.
BrennanConroy
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been zero test failures out of 1.5 million tests ran on the Win-VS2022 queue over the past month, while the Win11 queue has been very flaky (92 test failures out of 3.2 million over the same period). We originally moved the VS2022 queue over to the helix matrix due to flakiness caused by dotnet/dnceng#3844, but that hasn't repro'd in aspnetcore at all over the past 30 days.
As an example, our flakiest test over the past 30 days has been
Microsoft.AspNetCore.Components.Test.ComponentBaseTest.RendersAfterParametersSetAndInitAsyncTasksAreCompleted, which failed 5 times in 108 runs on the Win11 queue, but passed in all 59 of its runs on the VS2022 queue.