Identity metrics clean up #62671
Identity metrics clean up #62671
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the default metric value for unknown cases from _UNKNOWN to _OTHER across identity-related switch expressions, aligning with the correct metric nomenclature.
- Replaces
_UNKNOWNwith_OTHERinGetTokenPurpose - Replaces
_UNKNOWNwith_OTHERinGetPasswordResult - Replaces
_UNKNOWNwith_OTHERinGetUpdateType
Comments suppressed due to low confidence (3)
src/Identity/Extensions.Core/src/UserManagerMetrics.cs:172
- Add a unit test to verify that GetTokenPurpose returns "_OTHER" for unrecognized purposes.
_ => "_OTHER"
src/Identity/Extensions.Core/src/UserManagerMetrics.cs:207
- Add a unit test to verify that GetPasswordResult returns "_OTHER" for cases falling through the specified patterns.
_ => "_OTHER"
src/Identity/Extensions.Core/src/UserManagerMetrics.cs:247
- Add a unit test to verify that GetUpdateType returns "_OTHER" for unhandled UserUpdateType values.
_ => "_OTHER"
|
Is _UNKNOWN correct here |
| _checkPasswordCounter = _meter.CreateCounter<long>(CheckPasswordCounterName, "count", "The number of check password attempts. Only checks whether the password is valid and not whether the user account is in a state that can log in."); | ||
| _verifyTokenCounter = _meter.CreateCounter<long>(VerifyTokenCounterName, "count", "The number of token verification attempts."); | ||
| _generateTokenCounter = _meter.CreateCounter<long>(GenerateTokenCounterName, "count", "The number of token generation attempts."); | ||
| _createCounter = _meter.CreateCounter<long>(CreateCounterName, "{create}", "The number of users created."); |
There was a problem hiding this comment.
it counts users, so should it be
| _createCounter = _meter.CreateCounter<long>(CreateCounterName, "{create}", "The number of users created."); | |
| _createCounter = _meter.CreateCounter<long>(CreateCounterName, "{user}", "The number of users created."); |
?
There was a problem hiding this comment.
You'd like create, update and delete metrics to have a unit of {user}?
There was a problem hiding this comment.
the number of users create/deleted is the number of users.
The number of updates is not the number of users, so I'd prefer {update} for it. I don't see a strong reason for all three to have the same unit.
It's not a super-strong opinion, but I'd prefer the unit to align with what's documented in the description.
_OTHERis the correct value to use when give a value outside of the known set.