[release/2.3] Update branding to 2.3.5 #62711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR prepares for the upcoming 2.3.5 patch release by syncing baseline and patch version values across configuration files and adding an entry for the new patch in the patch configuration.
- Bumped
AspNetCorePatchVersionfrom 4 to 5 inversion.props - Updated baseline version to 2.3.4 and aligned the
Microsoft.Net.Http.Headerspackage version ineng/Baseline.xmlandeng/Baseline.Designer.props - Introduced an empty property group for
VersionPrefix2.3.5 ineng/PatchConfig.props
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| version.props | Updated <AspNetCorePatchVersion> from 4 to 5 |
| eng/PatchConfig.props | Added new <PropertyGroup> for VersionPrefix == '2.3.5' |
| eng/Baseline.xml | Changed <Baseline Version> to 2.3.4 and updated HTTP headers |
| eng/Baseline.Designer.props | Bumped AspNetCoreBaselineVersion and BaselinePackageVersion |
Comments suppressed due to low confidence (1)
eng/PatchConfig.props:40
- [nitpick] The
PackagesInPatchelement is empty for the 2.3.5 block. Consider adding a brief comment to explain that no packages require patching for this version, which will improve clarity for future maintainers.
<PropertyGroup Condition=" '$(VersionPrefix)' == '2.3.5' ">
|
Hi @@wtgodbe. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates baseline versions and package configurations across several files to prepare for the next patch release of ASP.NET Core. The changes ensure consistency in versioning and introduce configuration for a new patch version.
Baseline version updates:
eng/Baseline.Designer.props: UpdatedAspNetCoreBaselineVersionfrom2.3.3to2.3.4andBaselinePackageVersionforMicrosoft.Net.Http.Headersfrom2.3.0to2.3.4. [1] [2]eng/Baseline.xml: Updated baseline version from2.3.3to2.3.4and updated the package version forMicrosoft.Net.Http.Headersfrom2.3.0to2.3.4. [1] [2]Configuration for new patch version:
eng/PatchConfig.props: Added a new property group forVersionPrefix2.3.5, preparing for the next patch release.version.props: UpdatedAspNetCorePatchVersionfrom4to5to reflect the new patch version.