Baseline tests should check for all possible extensions of not expected files #62752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a regression in the template baseline tests by removing redundant file extension checks when determining which files to skip during template validation. The change specifically removes filtering for .csproj, .fsproj, .props, .sln, and .targets files, while preserving the exclusion of bin and obj directories.
- Removes hardcoded file extension filters from baseline test logic
- Maintains existing
binandobjdirectory exclusion patterns - Aligns with the stated goal of checking all "not expected" contents regardless of extension
.csproj
javiercn
approved these changes
Jul 17, 2025
|
This broke that is triggered only on PRs that change templates, so it was not triggered here. We should definitely change the condition to add triggering on change in template tests as well, @wtgodbe. I'll revert it and add that path. edit: edit2: |
This was referenced Jul 18, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #62593 renamed some template files, we could see additional files in templates structure. It could be visible only locally, in case the repository run template tests before and after the PR got in.
This revealed one issue with baseline tests: they would not fail, even if repository was creating a template with incorrect application structure, with three
.csprojfiles instead of only one.In the particular case of such rename, this behavior would not have been caught by the developer applying the change - for them, the additional dirs would not exist. This change does not aim at improving cleaning the repo from old assets. It is trying to fix possible other cases when we would have additional contents of extensions that we don't currently check for. Maybe there's a good reason we're not doing that. Currently, I don't see it, so I am posting this update.
Description
binandobjdirs should stay.Fixes #62746