Support all subscribers to OnNotFound
event
#62798
Open
+314
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External subscribers can set
NotFoundEventArgs.Path
Connected with risks listed in #62412. In this PR, the listed scenarios are treated as supported, excluding case "we have no router and the request has not started" where we are not able to render the path set by external subscriber and only re-execution could render the not found contents.
This PR focuses on fixing scenario "we have blazor's router and the request has not started, we allow the Router to render only if it has
NotFoundPage
parameter passed". It also adds tests for all the scenarios mentioned in the linked issue.Description
Router
ignored all event calls ifNotFoundPage
was not populated. That included a case of external subscriber that setNotFoundEventArgs.Path
.args.Path
as a request to render the contents in this path. In that case,Router
is able to find a component type by route and render it.Router.NotFoundPage
orNotFoundEventArgs.Path
. If both are defined, we should respectNotFoundEventArgs.Path
because it's easier to overwrite it. It can be used, e.g. like this:NavigationManager.OnNotFound
beforeRouter
does it. In case of custom router, it's enough to do it in itsOnParametersSet/Async
, in case of defaultRouter
, it's best to do it inApp.razor
.