Skip to content

Revert "Baseline tests should check for all possible extensions of not expected files" #62800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2025
Merged

Revert "Baseline tests should check for all possible extensions of not expected files" #62800

merged 1 commit into from
Jul 18, 2025
+9 −7

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Jul 18, 2025 •
edited
Loading

Reverts #62752. Otherwise we're hitting e.g.

 Templates.Test.BaselineTest.Template_Produces_The_Right_Set_Of_FilesAsync(arguments: "new webapiaot", expectedFiles: ["appsettings.Development.json", "appsettings.json", "Program.cs", "{ProjectName}.http", "Properties/launchSettings.json"]) [FAIL]
2025-07-18T10:12:56.2136848Z [xUnit.net 00:00:45.03]       Assert.Contains() Failure: Item not found in collection
2025-07-18T10:12:56.2144101Z [xUnit.net 00:00:45.03]       Collection: ["appsettings.Development.json", "appsettings.json", "Program.cs", "AspNet.bbodgsnrnn0m.http", "Properties/launchSettings.json"]
2025-07-18T10:12:56.2149708Z [xUnit.net 00:00:45.03]       Not found:  "AspNet.bbodgsnrnn0m.csproj"
2025-07-18T10:12:56.2158846Z [xUnit.net 00:00:45.03]       Stack Trace:
2025-07-18T10:12:56.2171727Z [xUnit.net 00:00:45.04]         /_/src/ProjectTemplates/test/Templates.Tests/BaselineTest.cs(95,0): at Templates.Test.BaselineTest.Template_Produces_The_Right_Set_Of_FilesAsync(String arguments, String[] expectedFiles)
2025-07-18T10:12:56.2178046Z [xUnit.net 00:00:45.04]         --- End of stack trace from previous location ---

https://helixr1107v0xdeko0k025g8.blob.core.windows.net/dotnet-aspnetcore-refs-pull-62414-merge-def57de839324dcc92/Templates.Tests--net10.0/1/console.5b6b9c66.log?helixlogtype=result&skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2025-07-18T11%3A28%3A28Z&ske=2025-07-18T12%3A28%3A28Z&sks=b&skv=2024-11-04&sv=2024-11-04&se=2025-07-18T12%3A28%3A28Z&sr=b&sp=rl&sig=mpa5aE54QrIgppgfUzhQoIc3HACd0PBd7pXVZCTQLYA%3D

We can re-do it with updated baseline once the yml gets edited to be triggered on template tests changes later. .yml does not need updates, the job was blocked from other reasons.
For now, the goal is to unblock CI.

@ilonatommy ilonatommy added this to the 10.0-preview7 milestone Jul 18, 2025
@ilonatommy ilonatommy self-assigned this Jul 18, 2025
@Copilot Copilot AI review requested due to automatic review settings July 18, 2025 11:52
@github-actions github-actions bot added the needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically label Jul 18, 2025
Copilot
Copilot AI reviewed Jul 18, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts a previous change that modified the baseline test logic for checking expected files in template generation. The revert is necessary to unblock CI failures where tests were failing due to missing generated files (like .csproj files) that weren't being properly handled by the baseline checks.

  • Reverts the IsIgnoredPath method extraction and returns to inline filtering logic
  • Adds back explicit file extension checks for project files (.csproj, .fsproj, .props, .sln, .targets)
  • Maintains the existing bin/ and obj/ directory filtering logic

@ilonatommy ilonatommy enabled auto-merge (squash) July 18, 2025 12:38
@gfoidl gfoidl added area-blazor Includes: Blazor, Razor Components and removed needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically labels Jul 18, 2025
@ilonatommy ilonatommy merged commit 773dd5a into main Jul 18, 2025
31 checks passed
@ilonatommy ilonatommy deleted the revert-62752-fix-62746 branch July 18, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@akoeplinger akoeplinger akoeplinger approved these changes

@javiercn javiercn Awaiting requested review from javiercn

@oroztocil oroztocil Awaiting requested review from oroztocil

@dariatiurina dariatiurina Awaiting requested review from dariatiurina

Assignees

@ilonatommy ilonatommy

Labels
area-blazor Includes: Blazor, Razor Components feature-templates test-failure
Projects
None yet
Milestone
10.0-preview7
Development

Successfully merging this pull request may close these issues.
3 participants
@ilonatommy @akoeplinger @gfoidl
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy