Changes in embedded dirs should also trigger templates testing #62806
Conversation
|
After the 1st commit: Testing what happens when I add changes from the PR that originally did not trigger this job either. |
|
Working: Removing the temporary change. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Azure DevOps pipeline trigger patterns to properly detect changes in deeply nested directories within the templates testing workflow. The change ensures that modifications to files embedded in subdirectories will trigger template tests, addressing an issue where a previous PR failed to trigger tests despite making changes in paths that should have been covered.
- Updated file matching patterns from single wildcard (*) to double wildcard (**) syntax
- Applied the change to three key source directories: ProjectTemplates, Components, and Mvc
There was a problem hiding this comment.
The reason for this was that the templates pipeline wasn't classified in Product Catalog, so nothing was able to trigger it. Dnceng fixed that yesterday. The single * is actually the correct syntax - you can confirm by opening a PR today against a file in an embedded dir
|
Thanks! |
Follow up for #62752 (comment).
Description
PR #6275 did not trigger the template test, even though its change was under path listed in trigger mechanisms:
aspnetcore/.azure/pipelines/template-tests-pr.yml
Line 19 in 366296c
Investigating further, we need double wildcard there if we want changes to files embedded deeper in the structure to also trigger the job:
https://learn.microsoft.com/en-us/azure/devops/pipelines/tasks/file-matching-patterns?view=azure-devops