Tests | Activate SplitPacket Tests #3061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Commenter does not have sufficient privileges for PR 3061 in repo dotnet/SqlClient |
paulmedynski
approved these changes
Mar 18, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3061 +/- ##
==========================================
- Coverage 72.68% 66.12% -6.57%
==========================================
Files 283 292 +9
Lines 58975 56691 -2284
==========================================
- Hits 42864 37485 -5379
- Misses 16111 19206 +3095
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mdaigle
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AI Blurp
This pull request includes several improvements and refactorings to the
SplitPacketTestclass and theDataTestUtilityclass in the Microsoft.Data.SqlClient test suite. The most important changes include adding new utility methods, refactoring existing methods, and enhancing the test class with proper resource disposal.Improvements and refactorings:
src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs: Added new methodsIsNotNamedInstanceandIsLocalHostto theDataTestUtilityclass for better connection string handling and test conditions.Enhancements to test class:
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/SplitPacketTest/SplitPacketTest.cs: Refactored theSplitPacketTestclass to use private fields with underscores, addedCancellationTokensupport to theSetupProxymethod, and implemented theIDisposableinterface for proper resource cleanup. [1] [2] [3] [4] [5]These changes enhance the code readability, maintainability, and ensure that resources are properly managed during the tests.
Human stuff
This removes the ActiveIssue 5538 from the SplitPacketTest
It makes sure that the test is only run on localhost and without named instances due to the fact that the tests are proxying the requests.
Also added IDisposable cleanup so that the started threads don't hang around.