Fix uninitted class variables from esp8266#7464

earlephilhower · earlephilhower · commit ed74febf5971 · 2020-07-22T20:26:59.000-07:00
PR esp8266#7464 removed the reset of client authentication settings when server authentication settings were changed, however it never did initialize the client authentication information to nullptr in the constructor. This can result in crashes during connections when client certs are not applied. Fix by resetting the client authenticaion variables on object construction.
diff --git a/libraries/ESP8266WiFi/src/WiFiClientSecureBearSSL.cpp b/libraries/ESP8266WiFi/src/WiFiClientSecureBearSSL.cpp
@@ -105,6 +105,9 @@ WiFiClientSecure::WiFiClientSecure() : WiFiClient() {
   _clear();
   _clearAuthenticationSettings();
   _certStore = nullptr; // Don't want to remove cert store on a clear, should be long lived
+  _sk = nullptr;
+  _axtls_chain = nullptr;
+  _axtls_sk = nullptr;
   stack_thunk_add_ref();
 }
 

Original file line number	Diff line number	Diff line change
`@@ -105,6 +105,9 @@ WiFiClientSecure::WiFiClientSecure() : WiFiClient() {`
`105`	`105`	`_clear();`
`106`	`106`	`_clearAuthenticationSettings();`
`107`	`107`	`_certStore = nullptr; // Don't want to remove cert store on a clear, should be long lived`
	`108`	`+ _sk = nullptr;`
	`109`	`+ _axtls_chain = nullptr;`
	`110`	`+ _axtls_sk = nullptr;`
`108`	`111`	`stack_thunk_add_ref();`
`109`	`112`	`}`
`110`	`113`