fix: Task exception was never retrieved when continue_ race with page closed event (microsoft#1167)

x0day · mxschmitt · web-flow · commit 1cce06a80f04 · 2022-02-23T13:16:50.000+01:00
closes microsoft#1165 Co-authored-by: Max Schmitt <max@schmitt.mx>
diff --git a/playwright/_impl/_network.py b/playwright/_impl/_network.py
@@ -285,10 +285,13 @@ async def _race_with_page_close(self, future: Coroutine) -> None:
             # When page closes or crashes, we catch any potential rejects from this Route.
             # Note that page could be missing when routing popup's initial request that
             # does not have a Page initialized just yet.
+            fut = asyncio.create_task(future)
             await asyncio.wait(
-                [asyncio.create_task(future), page._closed_or_crashed_future],
+                [fut, page._closed_or_crashed_future],
                 return_when=asyncio.FIRST_COMPLETED,
             )
+            if page._closed_or_crashed_future.done():
+                await asyncio.gather(fut, return_exceptions=True)
         else:
             await future
 
