Skip to content

[llvm-libc] Add wchar from llvm-libc to overlay mode #24710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[llvm-libc] Add wchar from llvm-libc to overlay mode #24710

wants to merge 1 commit into from

Conversation

google-yfyang
Copy link
Collaborator

Related issue #24493

@sbc100
Copy link
Collaborator

sbc100 commented Jul 15, 2025

Can you prefix the PR titles with [llvm-libc] ? (And start the description with a capital letter, and use the imperative voice, e.g. [llvm-libc] Add wchar)

sbc100
sbc100 reviewed Jul 15, 2025
View reviewed changes
Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % comment

@google-yfyang google-yfyang changed the title adding wchar from llvm-libc to Overlay mode [llvm-libc] Add wchar from llvm-libc to Overlay mode Jul 15, 2025
@google-yfyang google-yfyang changed the title [llvm-libc] Add wchar from llvm-libc to Overlay mode [llvm-libc] Add wchar from llvm-libc to overlay mode Jul 15, 2025
@google-yfyang google-yfyang force-pushed the main branch 3 times, most recently from c2330dd to 7fd5fc6 Compare July 17, 2025 15:13
@google-yfyang
Copy link
Collaborator Author

@sbc100 Can you take another look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbc100 sbc100 sbc100 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@google-yfyang @sbc100
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy